fix: CI exiting with non-zero code on post-install audit fails #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sounds like a special exit code - can't we just check for that instead of forcing composer to be limited? |
morrisonlevi
approved these changes
Sep 1, 2023
|
Changed to handle the exit code 5 specifically |
|
Do not merge yet. This should be fixed in the hotfix composer/composer just made (2.6.2). I'm re-running master to see if it still fails 👍 |
|
Fixed with 2.6.2. This PR is no longer relevant 👍 Closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The 8.0 and 8.1 web tests started failing on the CI a few hours ago. This is due to the 2.6.0 release of composer/composer, which includes #11362.
This PR sets the composer version of the failing tests to 2.5.6.This pull request modifies the Makefile command for composer update to handle exit code 5.
Readiness checklist
Reviewer checklist