Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement OTEL env var support for dd-trace-js #4248

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

khanayan123
Copy link
Collaborator

What does this PR do?

This implementation establishes a mapping mechanism between OpenTelemetry (OTEL) environment variables and Datadog (DD) environment variables, with DD variables taking precedence in cases where both are configured. Furthermore, it incorporates telemetry metrics to track instances where both OTEL and DD environment variables share the same mapping, as well as to monitor occurrences of invalid OTEL variables for which we do not offer support.

Motivation

To add support for configuring the tracer using OTEL env variables

@khanayan123 khanayan123 requested review from a team as code owners April 19, 2024 09:21
@khanayan123 khanayan123 requested a review from wconti27 April 19, 2024 09:21
Copy link

github-actions bot commented Apr 19, 2024

Overall package size

Self size: 6.38 MB
Deduped: 60.87 MB
No deduping: 61.15 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.7.0 16.71 MB 16.72 MB
@datadog/native-appsec 7.1.1 14.39 MB 14.4 MB
@datadog/pprof 5.2.0 8.84 MB 9.21 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.0 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.3 67.62 kB 731.01 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@khanayan123 khanayan123 changed the title implement OTEL env var support for node.js implement OTEL env var support for dd-trace-js Apr 19, 2024
@pr-commenter
Copy link

pr-commenter bot commented Apr 19, 2024

Benchmarks

Benchmark execution time: 2024-04-19 09:39:22

Comparing candidate commit 5a8dfc4 in PR branch khanayan123/otel-env-mapping with baseline commit c4c01e4 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 261 metrics, 5 unstable metrics.

@khanayan123 khanayan123 merged commit ffaf35e into master Apr 22, 2024
108 of 109 checks passed
@khanayan123 khanayan123 deleted the khanayan123/otel-env-mapping branch April 22, 2024 08:37
juan-fernandez pushed a commit that referenced this pull request Apr 22, 2024
* implement OTEL env var support for node.js
juan-fernandez pushed a commit that referenced this pull request Apr 22, 2024
* implement OTEL env var support for node.js
juan-fernandez pushed a commit that referenced this pull request Apr 22, 2024
* implement OTEL env var support for node.js
This was referenced Apr 22, 2024
juan-fernandez pushed a commit that referenced this pull request Apr 23, 2024
* implement OTEL env var support for node.js
juan-fernandez pushed a commit that referenced this pull request Apr 23, 2024
* implement OTEL env var support for node.js
juan-fernandez pushed a commit that referenced this pull request Apr 23, 2024
* implement OTEL env var support for node.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants