Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: upgrade github.com/go-jose/go-jose/v3 to v3.0.3 #2700

Merged
merged 3 commits into from
May 28, 2024

Conversation

darccio
Copy link
Contributor

@darccio darccio commented May 17, 2024

What does this PR do?

Upgrades github.com/go-jose/go-jose/v3 to v3.0.3.

Motivation

Comply with our internal vulnerability management policies.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented May 17, 2024

Benchmarks

Benchmark execution time: 2024-05-17 13:25:53

Comparing candidate commit 8b2e381 in PR branch dario.castane/VULN-5889/gojose-upgrade with baseline commit dfa02a3 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 0 unstable metrics.

@darccio darccio requested a review from a team May 28, 2024 10:51
Copy link
Contributor

@nsrip-dd nsrip-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a conflict in go.sum. The usual way I resolve these is to accept both changes and then just run go mod tidy again.

@darccio darccio enabled auto-merge (squash) May 28, 2024 12:58
@darccio darccio merged commit 464e078 into main May 28, 2024
157 of 158 checks passed
@darccio darccio deleted the dario.castane/VULN-5889/gojose-upgrade branch May 28, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants