Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: adding support of tags in remote sampling rules. #2676

Merged
merged 8 commits into from
May 8, 2024

Conversation

yuanyuanzhao3
Copy link
Collaborator

@yuanyuanzhao3 yuanyuanzhao3 commented Apr 29, 2024

What does this PR do?

Supporting sampling rules with tags matching from remote config.

A companion system test is added in DataDog/system-tests#2409

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

Sorry, something went wrong.

ddtrace/tracer/rules_sampler.go Outdated Show resolved Hide resolved
ddtrace/tracer/remote_config_test.go Outdated Show resolved Hide resolved
@yuanyuanzhao3 yuanyuanzhao3 requested a review from a team as a code owner May 7, 2024 21:28
@pr-commenter
Copy link

pr-commenter bot commented May 7, 2024

Benchmarks

Benchmark execution time: 2024-05-08 15:01:09

Comparing candidate commit d289bfc in PR branch yuanyuan.zhao/rc-sampling-rules-tags with baseline commit b4d38fc in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 0 unstable metrics.

@yuanyuanzhao3 yuanyuanzhao3 force-pushed the yuanyuan.zhao/rc-sampling-rules-tags branch from 0103d2f to eb35c47 Compare May 7, 2024 23:10
@yuanyuanzhao3 yuanyuanzhao3 requested a review from a team as a code owner May 8, 2024 13:13
Temporarily using `darccio/kafka` for a workaround.
Using the right tag for `darccio/kafka`.
@darccio darccio requested review from dianashevchenko and removed request for dianashevchenko May 8, 2024 14:28
@DataDog DataDog deleted a comment from dd-devflow bot May 8, 2024
@DataDog DataDog deleted a comment from dd-devflow bot May 8, 2024
@DataDog DataDog deleted a comment from dd-devflow bot May 8, 2024
@darccio darccio merged commit 64f2993 into main May 8, 2024
158 of 159 checks passed
@darccio darccio deleted the yuanyuan.zhao/rc-sampling-rules-tags branch May 8, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants