Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️[RUM-3234] Discard outdated vitals #2610

Merged
merged 6 commits into from
Mar 5, 2024

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Feb 16, 2024

Motivation

Avoid to report inflated vital values and to keep started vitals indefinitely in memory.

Changes

  • ♻️ Extract pageHistory.wasInPageStateDuringPeriod
  • ✨ discard a vital for which a frozen state happened
  • ✨ discard pending vitals on SESSION_RENEWED

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

Sorry, something went wrong.

@bcaudan bcaudan force-pushed the bcaudan/discard-outdated-vitals branch from ef163b7 to f2b7ff9 Compare February 16, 2024 15:43

Verified

This commit was signed with the committer’s verified signature.
bcaudan Bastien Caudan

Verified

This commit was signed with the committer’s verified signature.
bcaudan Bastien Caudan

Verified

This commit was signed with the committer’s verified signature.
bcaudan Bastien Caudan
@bcaudan bcaudan force-pushed the bcaudan/discard-outdated-vitals branch from f2b7ff9 to faa546f Compare February 16, 2024 15:47
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.87%. Comparing base (0c562b8) to head (6e587b9).

Files Patch % Lines
packages/rum-core/test/testSetupBuilder.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2610   +/-   ##
=======================================
  Coverage   92.87%   92.87%           
=======================================
  Files         237      237           
  Lines        6887     6896    +9     
  Branches     1508     1507    -1     
=======================================
+ Hits         6396     6405    +9     
  Misses        491      491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bcaudan bcaudan marked this pull request as ready for review February 16, 2024 15:52
@bcaudan bcaudan requested a review from a team as a code owner February 16, 2024 15:52
Copy link
Contributor

@N-Boutaib N-Boutaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bcaudan added 3 commits March 5, 2024 11:56

Verified

This commit was signed with the committer’s verified signature.
bcaudan Bastien Caudan

Verified

This commit was signed with the committer’s verified signature.
bcaudan Bastien Caudan

Verified

This commit was signed with the committer’s verified signature.
bcaudan Bastien Caudan
@bcaudan bcaudan merged commit 8f2d142 into main Mar 5, 2024
17 checks passed
@bcaudan bcaudan deleted the bcaudan/discard-outdated-vitals branch March 5, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants