-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Documents are not sliced during manifest generation (#5967) #5968
Fix: Documents are not sliced during manifest generation (#5967) #5968
Conversation
f2881ef
to
24cdb00
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5968 +/- ##
========================================
Coverage 85.17% 85.17%
========================================
Files 154 154
Lines 19893 19898 +5
========================================
+ Hits 16943 16948 +5
Misses 2950 2950 ☔ View full report in Codecov by Sentry. |
1efdfee
to
3cbd080
Compare
3cbd080
to
bde95c3
Compare
First commit resolves python-attrs/attrs#1081 which would become a problem on the 2nd commit |
a7358b3
to
33fdb29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some convention nits, otherwise, LGTM!
0f80558
to
1b49705
Compare
1bd8865
to
4166683
Compare
6238300
to
4e5ac02
Compare
Failed IT on anvilbox and hammerbox twice each.
|
2973957
to
b1dd698
Compare
Tested against a personal deployment resembling |
This avoids excessive string concatenation when enforcing them during field translation.
b1dd698
to
3fe7c4f
Compare
Connected issues: #5967
Checklist
Author
develop
issues/<GitHub handle of author>/<issue#>-<slug>
Author (partiality)
p
tag to titles of partial commitspartial
label to PR or this PR completely resolves all connected issuespartial
label1 when the issue title describes a problem, the corresponding PR
title is
Fix:
followed by the issue titleAuthor (reindex, API changes)
r
tag to commit title or this PR does not require reindexingreindex
label to PR or this PR does not require reindexingAPI
or this PR does not modify a REST APIa
(A
) tag to commit title for backwards (in)compatible changes or this PR does not modify a REST APIapp.py
or this PR does not modify a REST APIAuthor (chains)
base
label to the blocking PR or this PR is not chained to another PRchained
label to this PR or this PR is not chained to another PRAuthor (upgrading deployments)
make image_manifests.json
and committed any resulting changes or this PR does not modifyazul_docker_images
or any other variables referenced in the definition of that variableu
tag to commit title or this PR does not require upgrading deploymentsupgrade
label to PR or this PR does not require upgrading deploymentsAuthor (operator tasks)
Author (hotfixes)
F
tag to main commit title or this PR does not include permanent fix for a temporary hotfixprod
branch has no temporary hotfixes for any connected issuesAuthor (before every review)
develop
, squashed old fixupsmake requirements_update
or this PR does not touch requirements*.txt, common.mk, Makefile and DockerfileR
tag to commit title or this PR does not touch requirements*.txtreqs
label to PR or this PR does not touch requirements*.txtmake integration_test
passes in personal deployment or this PR does not touch functionality that could break the ITPeer reviewer (after requesting changes)
Uncheck the Author (before every review) checklists.
Peer reviewer (after approval)
System administrator (after requesting changes)
Uncheck the before every review checklists. Update the
N reviews
label.System administrator (after approval)
demo
orno demo
no demo
no sandbox
N reviews
label is accurateOperator (before pushing merge the commit)
reindex
label andr
commit title tagno demo
upgrade
develop
sandbox
label or PR is labeledno sandbox
dev
or PR is labeledno sandbox
anvildev
or PR is labeledno sandbox
anvilprod
or PR is labeledno sandbox
sandbox
deployment or PR is labeledno sandbox
anvilbox
deployment or PR is labeledno sandbox
hammerbox
deployment or PR is labeledno sandbox
sandbox
deployment or PR is labeledno sandbox
anvilbox
deployment or PR is labeledno sandbox
hammerbox
deployment or PR is labeledno sandbox
sandbox
or this PR does not remove catalogs or otherwise causes unreferenced indices indev
anvilbox
or this PR does not remove catalogs or otherwise causes unreferenced indices inanvildev
hammerbox
or this PR does not remove catalogs or otherwise causes unreferenced indices inanvilprod
sandbox
or this PR does not require reindexingdev
anvilbox
or this PR does not require reindexinganvildev
hammerbox
or this PR does not require reindexinganvilprod
sandbox
or this PR does not require reindexingdev
anvilbox
or this PR does not require reindexinganvildev
hammerbox
or this PR does not require reindexinganvilprod
p
if the PR is labeledpartial
Operator (chain shortening)
develop
or this PR is not labeledbase
chained
label from the blocked PR or this PR is not labeledbase
base
base
label from this PR or this PR is not labeledbase
Operator (after pushing the merge commit)
dev
or PR is labeledno sandbox
anvildev
or PR is labeledno sandbox
anvilprod
or PR is labeledno sandbox
dev
1dev
1anvildev
1anvildev
1anvilprod
1anvilprod
1dev
anvildev
anvilprod
1 When pushing the merge commit is skipped due to the PR being
labelled
no sandbox
, the next build triggered by a PR whose merge commit ispushed determines this checklist item.
Operator (reindex)
dev
or this PR does not remove catalogs or otherwise causes unreferenced indices indev
anvildev
or this PR does not remove catalogs or otherwise causes unreferenced indices inanvildev
anvilprod
or this PR does not remove catalogs or otherwise causes unreferenced indices inanvilprod
dev
or this PR does not merely remove sources from existing catalogs indev
anvildev
or this PR does not merely remove sources from existing catalogs inanvildev
anvilprod
or this PR does not merely remove sources from existing catalogs inanvilprod
dev
or this PR does not merely add sources to existing catalogs indev
anvildev
or this PR does not merely add sources to existing catalogs inanvildev
anvilprod
or this PR does not merely add sources to existing catalogs inanvilprod
dev
or this PR does not require reindexingdev
anvildev
or this PR does not require reindexinganvildev
anvilprod
or this PR does not require reindexinganvilprod
dev
or this PR does not require reindexingdev
anvildev
or this PR does not require reindexinganvildev
anvilprod
or this PR does not require reindexinganvilprod
dev
deployment or this PR does not require reindexingdev
anvildev
deployment or this PR does not require reindexinganvildev
anvilprod
deployment or this PR does not require reindexinganvilprod
Operator
Shorthand for review comments
L
line is too longW
line wrapping is wrongQ
bad quotesF
other formatting problem