fixes csv parse errors being silently ignored #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fatelei could you take a look? |
ok |
fatelei
approved these changes
May 10, 2023
mx-psi
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Dec 12, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/DATA-DOG/go-sqlmock](https://togithub.com/DATA-DOG/go-sqlmock) | require | patch | `v1.5.0` -> `v1.5.1` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>DATA-DOG/go-sqlmock (github.com/DATA-DOG/go-sqlmock)</summary> ### [`v1.5.1`](https://togithub.com/DATA-DOG/go-sqlmock/releases/tag/v1.5.1) [Compare Source](https://togithub.com/DATA-DOG/go-sqlmock/compare/v1.5.0...v1.5.1) Release was tested & verified using [aws-sqk ](https://togithub.com/aws/aws-xray-sdk-go/pull/450) ##### What's Changed - Add go 1.15 in travis by [@​gold-kou](https://togithub.com/gold-kou) in [DATA-DOG/go-sqlmock#234 - Update code sample by [@​ashhadsheikh](https://togithub.com/ashhadsheikh) in [DATA-DOG/go-sqlmock#244 - Fix ExpectedExec Stringer implementation by [@​maguro](https://togithub.com/maguro) in [DATA-DOG/go-sqlmock#249 - Add Multi Row Support by [@​asahasrabuddhe](https://togithub.com/asahasrabuddhe) in [DATA-DOG/go-sqlmock#263 - Add Go 1.16 and 1.17 to Travis by [@​gliptak](https://togithub.com/gliptak) in [DATA-DOG/go-sqlmock#279 - fix package by [@​col3name](https://togithub.com/col3name) in [DATA-DOG/go-sqlmock#284 - \[Chore]: Add Issue Template by [@​Ghvstcode](https://togithub.com/Ghvstcode) in [DATA-DOG/go-sqlmock#289 - Fix args passed not exp by [@​IvoGoman](https://togithub.com/IvoGoman) in [DATA-DOG/go-sqlmock#295 - fixes csv parse errors being silently ignored by [@​IvoGoman](https://togithub.com/IvoGoman) in [DATA-DOG/go-sqlmock#315 - CSVColParser: correctly set nil values in Rows by [@​IvoGoman](https://togithub.com/IvoGoman) in [DATA-DOG/go-sqlmock#318 - Modify: existing panic in AddRow to give a hint to the issue by [@​co60ca](https://togithub.com/co60ca) in [DATA-DOG/go-sqlmock#326 ##### New Contributors - [@​gold-kou](https://togithub.com/gold-kou) made their first contribution in [DATA-DOG/go-sqlmock#234 - [@​ashhadsheikh](https://togithub.com/ashhadsheikh) made their first contribution in [DATA-DOG/go-sqlmock#244 - [@​maguro](https://togithub.com/maguro) made their first contribution in [DATA-DOG/go-sqlmock#249 - [@​asahasrabuddhe](https://togithub.com/asahasrabuddhe) made their first contribution in [DATA-DOG/go-sqlmock#263 - [@​col3name](https://togithub.com/col3name) made their first contribution in [DATA-DOG/go-sqlmock#284 - [@​Ghvstcode](https://togithub.com/Ghvstcode) made their first contribution in [DATA-DOG/go-sqlmock#289 - [@​IvoGoman](https://togithub.com/IvoGoman) made their first contribution in [DATA-DOG/go-sqlmock#295 - [@​co60ca](https://togithub.com/co60ca) made their first contribution in [DATA-DOG/go-sqlmock#326 **Full Changelog**: DATA-DOG/go-sqlmock@v1.5.0...v1.5.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
](https://renovatebot.com){kind=link}
ti-chi-bot bot
pushed a commit
to PingCAP-QE/ee-apps
that referenced
this pull request
Feb 23, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/DATA-DOG/go-sqlmock](https://togithub.com/DATA-DOG/go-sqlmock) | `v1.5.0` -> `v1.5.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>DATA-DOG/go-sqlmock (github.com/DATA-DOG/go-sqlmock)</summary> ### [`v1.5.2`](https://togithub.com/DATA-DOG/go-sqlmock/releases/tag/v1.5.2) [Compare Source](https://togithub.com/DATA-DOG/go-sqlmock/compare/v1.5.1...v1.5.2) #### What's Changed ##### Fixes breaking change from: [DATA-DOG/go-sqlmock#295 - fix: make no argument passed validation opt-in by [@​IvoGoman](https://togithub.com/IvoGoman) in [DATA-DOG/go-sqlmock#329 **Full Changelog**: DATA-DOG/go-sqlmock@v1.5.1...v1.5.2 ### [`v1.5.1`](https://togithub.com/DATA-DOG/go-sqlmock/releases/tag/v1.5.1) [Compare Source](https://togithub.com/DATA-DOG/go-sqlmock/compare/v1.5.0...v1.5.1) Release was tested & verified using [aws-sqk ](https://togithub.com/aws/aws-xray-sdk-go/pull/450) ##### What's Changed - Add go 1.15 in travis by [@​gold-kou](https://togithub.com/gold-kou) in [DATA-DOG/go-sqlmock#234 - Update code sample by [@​ashhadsheikh](https://togithub.com/ashhadsheikh) in [DATA-DOG/go-sqlmock#244 - Fix ExpectedExec Stringer implementation by [@​maguro](https://togithub.com/maguro) in [DATA-DOG/go-sqlmock#249 - Add Multi Row Support by [@​asahasrabuddhe](https://togithub.com/asahasrabuddhe) in [DATA-DOG/go-sqlmock#263 - Add Go 1.16 and 1.17 to Travis by [@​gliptak](https://togithub.com/gliptak) in [DATA-DOG/go-sqlmock#279 - fix package by [@​col3name](https://togithub.com/col3name) in [DATA-DOG/go-sqlmock#284 - \[Chore]: Add Issue Template by [@​Ghvstcode](https://togithub.com/Ghvstcode) in [DATA-DOG/go-sqlmock#289 - Fix args passed not exp by [@​IvoGoman](https://togithub.com/IvoGoman) in [DATA-DOG/go-sqlmock#295 - fixes csv parse errors being silently ignored by [@​IvoGoman](https://togithub.com/IvoGoman) in [DATA-DOG/go-sqlmock#315 - CSVColParser: correctly set nil values in Rows by [@​IvoGoman](https://togithub.com/IvoGoman) in [DATA-DOG/go-sqlmock#318 - Modify: existing panic in AddRow to give a hint to the issue by [@​co60ca](https://togithub.com/co60ca) in [DATA-DOG/go-sqlmock#326 ##### New Contributors - [@​gold-kou](https://togithub.com/gold-kou) made their first contribution in [DATA-DOG/go-sqlmock#234 - [@​ashhadsheikh](https://togithub.com/ashhadsheikh) made their first contribution in [DATA-DOG/go-sqlmock#244 - [@​maguro](https://togithub.com/maguro) made their first contribution in [DATA-DOG/go-sqlmock#249 - [@​asahasrabuddhe](https://togithub.com/asahasrabuddhe) made their first contribution in [DATA-DOG/go-sqlmock#263 - [@​col3name](https://togithub.com/col3name) made their first contribution in [DATA-DOG/go-sqlmock#284 - [@​Ghvstcode](https://togithub.com/Ghvstcode) made their first contribution in [DATA-DOG/go-sqlmock#289 - [@​IvoGoman](https://togithub.com/IvoGoman) made their first contribution in [DATA-DOG/go-sqlmock#295 - [@​co60ca](https://togithub.com/co60ca) made their first contribution in [DATA-DOG/go-sqlmock#326 **Full Changelog**: DATA-DOG/go-sqlmock@v1.5.0...v1.5.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/PingCAP-QE/ee-apps). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuMjAwLjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change the
FromCSVStringwould return a subset of rows in casecsvReader.Read()returns an error but ignore the error itself.E.g.
The second line will result in a
ErrQuotebut the error is not handled. Instead the first row and no error are returned. This will then lead to undesired behavior of tests relying on this data.The method
FromCSVStringalready runs into a panic if the number of columns do not match. Therefore, I propose that an invalid input should run into a panic as well.All errors returned by
csvreader.Read, besides fromio.EOF, should lead to a panic, as they indicate the csv string could not properly be parsed.