feat: sort components #624
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caroline Russell <caroline@appthreat.dev>
prabhu
reviewed
Oct 10, 2023
| @@ -631,6 +631,7 @@ export function listComponents( | |||
| const compMap = {}; | |||
| const isRootPkg = ptype === "npm"; | |||
| if (Array.isArray(pkg)) { | |||
| pkg.sort((a, b) => a.name.localeCompare(b.name)); | |||
There was a problem hiding this comment.
Maybe sort by purl which also includes group? Also there could be a comparator function used somewhere
|
@prabhu I looked at the componentSorter in utils, and that is ok, but it ends up sorting by group, where available. Although this makes some sense, it helps very little as a user trying to locate a specific package on the list - and that is the problem I sought to address. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sorting of components.