Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable check shadowing in govet linter #397

Merged
merged 2 commits into from
May 5, 2023
Merged

Disable check shadowing in govet linter #397

merged 2 commits into from
May 5, 2023

Conversation

jtraglia
Copy link
Contributor

@jtraglia jtraglia commented May 5, 2023

This PR removes the linter-settings block which enables check-shadowing. Personally, I don't find this check all that useful; it's not necessarily dangerous and making new variables like err2 and err3 is pretty ugly IMO.

@jtraglia
Copy link
Contributor Author

jtraglia commented May 5, 2023

Also worth mentioning, the .golangci.yml file in gnark doesn't have this either:

@gbotrel gbotrel merged commit 2fde31d into Consensys:develop May 5, 2023
6 checks passed
@jtraglia jtraglia deleted the disable-check-shadowing branch May 5, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbotrel gbotrel gbotrel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtraglia @gbotrel