Fix Memory leak on Popup #1398
Merged
Fix Memory leak on Popup #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladislavAntonyuk
previously approved these changes
Sep 11, 2023
Both `CloseAsync(object)` and `OnDismissedByTappingOutsideOfPopup()` `await` the `OnClosed(object, bool)` method. We can just set the Parent reference to `null` in `OnClosed(object,bool)` and remove the now unused field.
brminnick
previously approved these changes
Sep 23, 2023
brminnick
approved these changes
Sep 23, 2023
6 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR null the
Popup.Parentto prevent memory leaks, it will mostly occur when the parent is aMainPage(root page) orShell.Probably, you may think "Wait, but .NET MAUI doesn't handle that internally?", yeah it does but for
VisualElement,Popupis anElementand doesn't get all this love, so we need to do that by ourselves. :/Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
Before:
You see the CustomPopup holding on memory.
After:
No more references to it, YaY: