Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the validation to allow the image button to apply the tint co… #1386

Merged
merged 5 commits into from
Sep 7, 2023

Conversation

vhugogarcia
Copy link
Contributor

@vhugogarcia vhugogarcia commented Sep 5, 2023

Description of Change

Updated the iOS validations to allow the Image button and image to re-apply the tint color when the source is updated via a page element event. Special thanks to v0idzz for providing a proposal solution.

Linked Issues

PR Checklist

Additional information

Additionally, I went head and updated a little the UI of the sample app for the Image Tint Color to reflect make it a little more clear and also added the sample of a change source image button, so it can be applied.

No documentation is required to be updated, since this was an iOS bug only. It has been tested on iOS.

Simulator Screenshot - iPhone 11 Pro Max - 2023-09-05 at 08 43 37

pictos
pictos previously approved these changes Sep 6, 2023
Copy link
Collaborator

@brminnick brminnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vhugogarcia!!

And thank you SO MUCH for including a sample! I heavily use the sample app to validate PRs to ensure that all existing functionality continues to work, and this addition to the sample app will help ensure a future PR doesn't accidentally break it! ❤️🙌

@brminnick brminnick enabled auto-merge (squash) September 7, 2023 17:59
@brminnick brminnick merged commit f140a3a into main Sep 7, 2023
7 checks passed
@brminnick brminnick deleted the vh/bug-icon-tint-color-behavior branch September 7, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] IconTintColorBehavior stops working after changing Image Source on iOS
4 participants