Add `MemoryAnalyzer` roslyn analyzer #1371

brminnick · 2023-08-27T17:26:45Z

Description of Change

This PR adds a new Roslyn Analyzer: MemoryAnalyzers, a set of Roslyn C# code analyzers for finding memory leaks in iOS and MacCatalyst applications, created by @jonathanpeppers on Microsoft's .NET MAUI team.

The .NET MAUI team adopted MemoryAnalyzers, adding it to their code base in this PR last week: https://github.com/dotnet/maui/pull/16346/files

This PR also implements updates to our code base where MemoryAnalyzers found potential memory leaks.

PR Checklist

Rebased on top of main at time of PR
Changes adhere to coding standard

Additional information

I've also added WarningsAsErrors for the current 3 warnings surfaced by MemoryAnalyzer to ensure future PRs don't accidentally introduce new memory leaks: MA0001, MA0002 and MA0003

jonathanpeppers

Overall, my main concern is no tests were added here. The analyzer can point out potential issues, but it can't actually verify correctness like things at runtime can.

Do you have on-device tests that can do things like mentioned here?

https://github.com/dotnet/maui/wiki/Memory-Leaks#writing-tests

jonathanpeppers · 2023-08-28T13:51:31Z

src/CommunityToolkit.Maui.Core/Views/DrawingView/PlatformView/MauiDrawingView.shared.cs

-	public Action<ICanvas, RectF>? DrawAction { get; set; }
+	public Action<ICanvas, RectF>? DrawAction


FYI, if someone uses this property, the caller would need to store the delegate in a member field, or the GC will collect it.

Some examples on this here:

https://github.com/dotnet/maui/wiki/Memory-Leaks#when-we-cant-use-weakeventmanager

I would write a test to ensure this callback still works after the GC runs.

jonathanpeppers · 2023-08-28T13:53:21Z

src/CommunityToolkit.Maui.Core/Views/DrawingView/PlatformView/MauiDrawingView.shared.cs

+
+		public void SubscribeCollectionChanged()
+		{
+			PlatformView.Lines.CollectionChanged += PlatformView.OnLinesCollectionChanged;


This Lines object will still hold a strong reference to the PlatformView here. This could be OK as long as Lines isn't an NSObject, what is it?

Lines is an ObservableCollection

* Popup v6 windows (#1086) Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Shaun Lawrence <shaunrlawrence@gmail.com> * ♻️ [Housekeeping] Fixed GravatarImageSourceTests.TestDefaultStream (#1335) * [housekeeping] Automated PR to fix formatting errors (#1327) * Fix popup margin on iOS (#1329) * Bump NuGet.Protocol from 6.6.1 to 6.7.0 in /samples (#1330) * Use fully qualified namespace for Color reference in TextToColorGenerator (#1332) * Use fully qualified namespace for Color reference in TextToColorGenerator to prevent collisions This change should prevent "ambiguous reference" error to occur when other packages are included in a MAUI project that provide their own Color objects * added global prefix to be safer --------- Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> * Code cleanup and preparation for the next release (breaking changes) (#1324) * Code cleanup and preparation for .net 8 * Update CompareConverter.shared.cs * Revert global.json * More CleanUps * Remove redundant TrySetCanceled and rely on speech recognition result * Update Formatting --------- Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> * Fix Gestures on Popup on ios (#1342) * Fix Gestures on Popup on ios * don't query type cast directly * Code for AddLogicalChild (.NET 8) * reduce changes * setting the parent fixes the BindingContext of the view * Revert "setting the parent fixes the BindingContext of the view" This reverts commit 0a64b56. * reduce changes * simplify code * fixing build * assigned Element to contentPage.Parent --------- Co-authored-by: pedrojesus <pedrojesus.cefet@gmail.com> * `global.json`: Change `"rollForward": "latestMajor",` -> `"rollForward": "latestFeature"`. (#1338) Update global.json * Bump Microsoft.NET.Test.Sdk from 17.7.0 to 17.7.1 in /samples (#1348) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.7.0 to 17.7.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.7.0...v17.7.1) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 632 bug avatar view clipping on windows (#1344) * Resolves issue on Windows where the splash screen icon is not found. * Resolves an issue with the 'Ratings' sample for AvatarView. * Spaces and not tabs * Spaces and not tabs * Changed MauiImage to point to Images folder. * Changed splash for Windows to be Resize=False * Typo in name of MauiImage * Try to prevent locking. * Bump Microsoft.CodeAnalysis from 4.6.0 to 4.7.0 in /samples (#1355) * Bump Microsoft.CodeAnalysis.CSharp.Workspaces from 4.6.0 to 4.7.0 in /samples (#1357) * Bump FluentAssertions from 6.11.0 to 6.12.0 in /samples (#1365) * fix IconTintColorBehavior for Windows (#1370) fix IconTintColorBehavior for windows Co-authored-by: Oleksii <sokol@managed-code.com> * Add `MemoryAnalyzer` roslyn analyzer (#1371) * Add NuGet Package + Update `WarningsAsErrors` * Fix MA0002 * Fix `MauiDrawingView` * Fix `MauiPopup` * Fix Naming * return `null` for nullable references * Use Ternary Operator * `dotnet format` * iOS popup fix with Shell or TabbedPage (#1343) * Fix Issue #1256 Better fix * Fixed Popup on Multiple Level Pages (#822) --------- Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> * [housekeeping] Automated PR to fix formatting errors (#1373) * Bump Microsoft.NET.Test.Sdk from 17.7.1 to 17.7.2 in /samples (#1378) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Shaun Lawrence <shaunrlawrence@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: cat0363 <125236133+cat0363@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wolf <132034537+wolfgang-ironsoftware@users.noreply.github.com> Co-authored-by: Thomas Stocker <thomas.stocker@gmail.com> Co-authored-by: George Leithead <github@internetwideworld.com> Co-authored-by: Sokol2001 <53799292+Sokol2001@users.noreply.github.com> Co-authored-by: Oleksii <sokol@managed-code.com> Co-authored-by: Andrey Onishchenko <100789522+cucumber-sp@users.noreply.github.com>

This reverts commit 054f521.

* Popup v6 windows (CommunityToolkit#1086) Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Shaun Lawrence <shaunrlawrence@gmail.com> * ♻️ [Housekeeping] Fixed GravatarImageSourceTests.TestDefaultStream (CommunityToolkit#1335) * [housekeeping] Automated PR to fix formatting errors (CommunityToolkit#1327) * Fix popup margin on iOS (CommunityToolkit#1329) * Bump NuGet.Protocol from 6.6.1 to 6.7.0 in /samples (CommunityToolkit#1330) * Use fully qualified namespace for Color reference in TextToColorGenerator (CommunityToolkit#1332) * Use fully qualified namespace for Color reference in TextToColorGenerator to prevent collisions This change should prevent "ambiguous reference" error to occur when other packages are included in a MAUI project that provide their own Color objects * added global prefix to be safer --------- Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> * Code cleanup and preparation for the next release (breaking changes) (CommunityToolkit#1324) * Code cleanup and preparation for .net 8 * Update CompareConverter.shared.cs * Revert global.json * More CleanUps * Remove redundant TrySetCanceled and rely on speech recognition result * Update Formatting --------- Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> * Fix Gestures on Popup on ios (CommunityToolkit#1342) * Fix Gestures on Popup on ios * don't query type cast directly * Code for AddLogicalChild (.NET 8) * reduce changes * setting the parent fixes the BindingContext of the view * Revert "setting the parent fixes the BindingContext of the view" This reverts commit 0a64b56. * reduce changes * simplify code * fixing build * assigned Element to contentPage.Parent --------- Co-authored-by: pedrojesus <pedrojesus.cefet@gmail.com> * `global.json`: Change `"rollForward": "latestMajor",` -> `"rollForward": "latestFeature"`. (CommunityToolkit#1338) Update global.json * Bump Microsoft.NET.Test.Sdk from 17.7.0 to 17.7.1 in /samples (CommunityToolkit#1348) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.7.0 to 17.7.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.7.0...v17.7.1) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 632 bug avatar view clipping on windows (CommunityToolkit#1344) * Resolves issue on Windows where the splash screen icon is not found. * Resolves an issue with the 'Ratings' sample for AvatarView. * Spaces and not tabs * Spaces and not tabs * Changed MauiImage to point to Images folder. * Changed splash for Windows to be Resize=False * Typo in name of MauiImage * Try to prevent locking. * Bump Microsoft.CodeAnalysis from 4.6.0 to 4.7.0 in /samples (CommunityToolkit#1355) * Bump Microsoft.CodeAnalysis.CSharp.Workspaces from 4.6.0 to 4.7.0 in /samples (CommunityToolkit#1357) * Bump FluentAssertions from 6.11.0 to 6.12.0 in /samples (CommunityToolkit#1365) * fix IconTintColorBehavior for Windows (CommunityToolkit#1370) fix IconTintColorBehavior for windows Co-authored-by: Oleksii <sokol@managed-code.com> * Add `MemoryAnalyzer` roslyn analyzer (CommunityToolkit#1371) * Add NuGet Package + Update `WarningsAsErrors` * Fix MA0002 * Fix `MauiDrawingView` * Fix `MauiPopup` * Fix Naming * return `null` for nullable references * Use Ternary Operator * `dotnet format` * iOS popup fix with Shell or TabbedPage (CommunityToolkit#1343) * Fix Issue CommunityToolkit#1256 Better fix * Fixed Popup on Multiple Level Pages (CommunityToolkit#822) --------- Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> * [housekeeping] Automated PR to fix formatting errors (CommunityToolkit#1373) * Bump Microsoft.NET.Test.Sdk from 17.7.1 to 17.7.2 in /samples (CommunityToolkit#1378) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Shaun Lawrence <shaunrlawrence@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: cat0363 <125236133+cat0363@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wolf <132034537+wolfgang-ironsoftware@users.noreply.github.com> Co-authored-by: Thomas Stocker <thomas.stocker@gmail.com> Co-authored-by: George Leithead <github@internetwideworld.com> Co-authored-by: Sokol2001 <53799292+Sokol2001@users.noreply.github.com> Co-authored-by: Oleksii <sokol@managed-code.com> Co-authored-by: Andrey Onishchenko <100789522+cucumber-sp@users.noreply.github.com>

* init * code style * android bits * code style * dumb sample to test * added a11y and initialization * code style * improved sample * code style * protect against NRE * windows implementation * code style * Added comments to all public methods to enable builds without errors * Missed some docs required for building * Touch effect maui (#1326) * Fixed some issues in Android implementation * Added iOS implementation for TouchBehavior * Reformatted code * Removed duplicated extension methods --------- Co-authored-by: Christian Rendl <cr@mutor.at> * Bringing touch-effect up to date with main (#1383) * Popup v6 windows (#1086) Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Shaun Lawrence <shaunrlawrence@gmail.com> * ♻️ [Housekeeping] Fixed GravatarImageSourceTests.TestDefaultStream (#1335) * [housekeeping] Automated PR to fix formatting errors (#1327) * Fix popup margin on iOS (#1329) * Bump NuGet.Protocol from 6.6.1 to 6.7.0 in /samples (#1330) * Use fully qualified namespace for Color reference in TextToColorGenerator (#1332) * Use fully qualified namespace for Color reference in TextToColorGenerator to prevent collisions This change should prevent "ambiguous reference" error to occur when other packages are included in a MAUI project that provide their own Color objects * added global prefix to be safer --------- Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> * Code cleanup and preparation for the next release (breaking changes) (#1324) * Code cleanup and preparation for .net 8 * Update CompareConverter.shared.cs * Revert global.json * More CleanUps * Remove redundant TrySetCanceled and rely on speech recognition result * Update Formatting --------- Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> * Fix Gestures on Popup on ios (#1342) * Fix Gestures on Popup on ios * don't query type cast directly * Code for AddLogicalChild (.NET 8) * reduce changes * setting the parent fixes the BindingContext of the view * Revert "setting the parent fixes the BindingContext of the view" This reverts commit 0a64b56. * reduce changes * simplify code * fixing build * assigned Element to contentPage.Parent --------- Co-authored-by: pedrojesus <pedrojesus.cefet@gmail.com> * `global.json`: Change `"rollForward": "latestMajor",` -> `"rollForward": "latestFeature"`. (#1338) Update global.json * Bump Microsoft.NET.Test.Sdk from 17.7.0 to 17.7.1 in /samples (#1348) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.7.0 to 17.7.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.7.0...v17.7.1) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 632 bug avatar view clipping on windows (#1344) * Resolves issue on Windows where the splash screen icon is not found. * Resolves an issue with the 'Ratings' sample for AvatarView. * Spaces and not tabs * Spaces and not tabs * Changed MauiImage to point to Images folder. * Changed splash for Windows to be Resize=False * Typo in name of MauiImage * Try to prevent locking. * Bump Microsoft.CodeAnalysis from 4.6.0 to 4.7.0 in /samples (#1355) * Bump Microsoft.CodeAnalysis.CSharp.Workspaces from 4.6.0 to 4.7.0 in /samples (#1357) * Bump FluentAssertions from 6.11.0 to 6.12.0 in /samples (#1365) * fix IconTintColorBehavior for Windows (#1370) fix IconTintColorBehavior for windows Co-authored-by: Oleksii <sokol@managed-code.com> * Add `MemoryAnalyzer` roslyn analyzer (#1371) * Add NuGet Package + Update `WarningsAsErrors` * Fix MA0002 * Fix `MauiDrawingView` * Fix `MauiPopup` * Fix Naming * return `null` for nullable references * Use Ternary Operator * `dotnet format` * iOS popup fix with Shell or TabbedPage (#1343) * Fix Issue #1256 Better fix * Fixed Popup on Multiple Level Pages (#822) --------- Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> * [housekeeping] Automated PR to fix formatting errors (#1373) * Bump Microsoft.NET.Test.Sdk from 17.7.1 to 17.7.2 in /samples (#1378) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Shaun Lawrence <shaunrlawrence@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: cat0363 <125236133+cat0363@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wolf <132034537+wolfgang-ironsoftware@users.noreply.github.com> Co-authored-by: Thomas Stocker <thomas.stocker@gmail.com> Co-authored-by: George Leithead <github@internetwideworld.com> Co-authored-by: Sokol2001 <53799292+Sokol2001@users.noreply.github.com> Co-authored-by: Oleksii <sokol@managed-code.com> Co-authored-by: Andrey Onishchenko <100789522+cucumber-sp@users.noreply.github.com> * Added MacOS and brought across the sample page style from XCT * Added TouchBehavior Unit Tests * Fixed issue with hover * Fix Rebase Issues Git didnt pick up all the changes and the rebase left some files in a wierd way. I have restored broken files to their state on main * Manual fixes for rebase collisions Some changes from the rebase had to be manually backed out by hand, I've restored the file from main which should be enough to revert the changes. * Moved sample page to gallery The sample page is now in the proper location, all of the shell wiring has been done. I have refactored the command code to live in the viewmodel and use the source generators. The sample isn't binding at this current time, I will have to investigate. * Fixed behavior binding The binding context wasnt being set on the platform behavior. We will need to understand the impact of this going forwards, see #795 * Fixed binding in sample Updated to remove the binding context from the platform behavior, we use a relative binding to talk to the viewmodel now * Added input transparency test case There is now an example of the control design that fails to register inputs, even when transparency is opted into * Fix issue with input transparency The issue I discovered where iOS would not set input transparency if the first child was a layout has now been resolved. * Fixed Parent Child Taps There was an issue in the sample where when tapping the parent/child view inside the child, both commands would execute. I have fixed this aswell as making sure the other behaviors arent affected * Fixed Hover The hovering now works correctly, we missed one area to force the ui to update * Fixed Ripple View Positioning The ripple view now positions correctly when there are child views in a layout. * Code styling Removing private & internal everywhere it can be removed. Removed some unused properties and cleaned up some nullable bits * Dotnet format Ran dotnet format, only checked in files related to touch behavior * Replaced Console with Trace As requested in the code review * Update GestureManager.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * Code review changes Updating null checks to pattern matching, some tweaks & implementing suggestions from Pedro * Code Review - Use `static` when possible - Use `TimeSpan` for Duration - Properly Implement Async/Await - Properly Dispose - Use PatternMatching for Enum - Move Primatives to CommunityToolkit.Maui.Core * Remove duplicate `ColorTo` extension * Fix Windows The touch behavior was token by the cancellation token changes. I'm not sure if passing none is the best idea, we possibly need to generate a real one? * Fixed unit tests * Use `uint` for Duration * Use `int` for Duration * Add TouchBehaviorDefaults * Update Unit Tests * Remove duplicate calls to `ConfigureAwaitOptions.ForceYielding` * `dotnet format` * Add nullability to `PressedBackgroundColor` * Remove Unused Internal Properties * Resolve Windows Compiler Errors * `dotnet format` * Remove duplicate `splash.svg` * Update formatting * Update Formatting * Fix Find + Replace Error * Use Primary Constructors * Fix find + replace error * Update StatusBarBehavior.shared.cs * Fix Splash Screen * Fix LongPress Gesture * Update Unit Tests * Fix Build Errors on Windows * `dotnet format` * Fix duplicate SplashScreen * Revert splashscreen svg * Update CommunityToolkit.Maui.Sample.csproj * Add Unit Tests for CurrentStateChanged * Add `CanExecuteTest` * Add Unit Tests * Update src/CommunityToolkit.Maui/Behaviors/PlatformBehaviors/Touch/TouchBehavior.android.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * remove the ShouldUseNativeAnimation check in order to make it work * throw ObjectDisposedException * Big Fixes + Performance Improvements * Remove `IsToggled` * Update GestureManager.cs * Rename `PulseCount` -> `RepeatAnimationCount` * Prevent animations from happening immediately when the TouchBehavior is attached * Rename `Normal` -> `Default` * Cerate `ImageTouchBehavior` * Move `SafeFireAndForgotExtensions` * Update XML Documentation * Fix Windows Build Errors * Remove White Box * `Normal` -> `Default` * Fix Touch + Hover logic for ImageSource * Remove `RepeatAnimationCount` * Remove `RepeatAnimationCount` * Fix `SetImageSource` * `ContentVIew` -> `BoxView` * Indicate Pressed and Released are Handled Set e.Handled on PointerPressed and PointerReleased to stop passing to child controls on windows. * Remove BoxView * FIx Hover / Touch Logic in SetImageSource * Refactor GestureManager, Add StateMachine tests * Remove Unused + Duplicate Code * Rename TouchBeahavior.methods.shared.cs * Remove NativeAnimation Logic * Remove NativeAnimation from Sample * Fix Windows Build Errors * Rename file * Update ImageTouchBehaviorTests.cs * Update ImageTouchBehaviorTests.cs * Update ImageTouchBehaviorTests.cs * Update ImageTouchBehaviorTests.cs * Update ImageTouchBehaviorTests.cs * Fix merge conflicts * Fix build error --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> Co-authored-by: Kym Phillpotts <kphillpotts@gmail.com> Co-authored-by: Christian Rendl <10274479+christianrr@users.noreply.github.com> Co-authored-by: Christian Rendl <cr@mutor.at> Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com> Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Shaun Lawrence <shaunrlawrence@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: cat0363 <125236133+cat0363@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wolf <132034537+wolfgang-ironsoftware@users.noreply.github.com> Co-authored-by: Thomas Stocker <thomas.stocker@gmail.com> Co-authored-by: George Leithead <github@internetwideworld.com> Co-authored-by: Sokol2001 <53799292+Sokol2001@users.noreply.github.com> Co-authored-by: Oleksii <sokol@managed-code.com> Co-authored-by: Andrey Onishchenko <100789522+cucumber-sp@users.noreply.github.com> Co-authored-by: Gerald Versluis <gerald@verslu.is>

brminnick added 6 commits August 27, 2023 16:19

Add NuGet Package + Update WarningsAsErrors

c091ad2

Fix MA0002

c401920

Fix MauiDrawingView

6421b61

Fix MauiPopup

3ec11c4

Fix Naming

3c0b051

return null for nullable references

d901404

brminnick requested a review from VladislavAntonyuk August 27, 2023 17:26

brminnick mentioned this pull request Aug 27, 2023

Add NuGet Badge to README jonathanpeppers/memory-analyzers#5

Merged

brminnick added 2 commits August 27, 2023 19:46

Use Ternary Operator

78b23af

dotnet format

75386fb

VladislavAntonyuk approved these changes Aug 27, 2023

View reviewed changes

brminnick merged commit 054f521 into main Aug 27, 2023
8 checks passed

brminnick deleted the Add-`MemoryAnalyzer`-Roslyn-Analyzer branch August 27, 2023 19:23

jonathanpeppers reviewed Aug 28, 2023

View reviewed changes

brminnick added the needs discussion Discuss it on the next Monthly standup label Sep 7, 2023

brminnick added a commit that referenced this pull request Sep 7, 2023

Revert "Add MemoryAnalyzer roslyn analyzer (#1371)"

d4cf145

This reverts commit 054f521.

This was referenced Sep 7, 2023

Revert MemoryAnalyzer PR Until Device Unit Testing is Available #1391

Merged

[Proposal] Add MemoryAnalyzer #1392

Open

brminnick removed the needs discussion Discuss it on the next Monthly standup label May 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `MemoryAnalyzer` roslyn analyzer #1371

Add `MemoryAnalyzer` roslyn analyzer #1371

brminnick commented Aug 27, 2023 •

edited

jonathanpeppers left a comment

jonathanpeppers Aug 28, 2023

jonathanpeppers Aug 28, 2023

brminnick Aug 28, 2023

		public Action<ICanvas, RectF>? DrawAction { get; set; }
		public Action<ICanvas, RectF>? DrawAction

Add MemoryAnalyzer roslyn analyzer #1371

Add MemoryAnalyzer roslyn analyzer #1371

Conversation

brminnick commented Aug 27, 2023 • edited

Description of Change

PR Checklist

Additional information

jonathanpeppers left a comment

Choose a reason for hiding this comment

jonathanpeppers Aug 28, 2023

Choose a reason for hiding this comment

jonathanpeppers Aug 28, 2023

Choose a reason for hiding this comment

brminnick Aug 28, 2023

Choose a reason for hiding this comment

Add `MemoryAnalyzer` roslyn analyzer #1371

Add `MemoryAnalyzer` roslyn analyzer #1371

brminnick commented Aug 27, 2023 •

edited