Call InvalidateMeasure on DockLayout when properties change affecting layout #1258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When properties are updated affecting layout,
InvalidateMeasure
should be called to trigger the layout to happen, normally called via a propertyChanged notification. This PR adds that forDockLayout
. TheInvalidateMeasure
method added here is similar to what's called for Grid properties in the MAUI repo.Linked Issues
PR Checklist
approved
(bug) orChampioned
(feature/proposal)main
at time of PRAdditional information
Note that I attempted adding unit tests, but none of my attempts were able to catch the behavior difference when
InvalidateMeasure
is called. This may be something normally done by "device tests" in the MAUI repo. So I ended up just testing manually against my test repo, which all looked good.