Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Popup.CloseAsync() #1223

Merged
merged 14 commits into from
Jul 10, 2023
Merged

Add Popup.CloseAsync() #1223

merged 14 commits into from
Jul 10, 2023

Conversation

brminnick
Copy link
Collaborator

@brminnick brminnick commented Jun 6, 2023

Description of Change

This PR adds a new API to Popup: Task Popup.CloseAsync()

Linked Issues

PR Checklist

Additional information

@brminnick
Copy link
Collaborator Author

Hey @JoonghyunCho! We're seeing a Tizen error in the build. Could you take a look?
https://dev.azure.com/dotnet/CommunityToolkit/_build/results?buildId=94166&view=logs&j=67da6a11-18ef-5f70-9b43-fae7e6c83e18&t=49ed9970-d038-52c3-9405-25559677b293&l=575

C:\hostedtoolcache\windows\dotnet\packs\Samsung.Tizen.Sdk\7.0.114\targets\Samsung.Tizen.Sdk.Packaging.targets(161,5): error : The api-version specified in tizen-manifest file is 7. [D:\a\1\s\samples\CommunityToolkit.Maui.Sample\CommunityToolkit.Maui.Sample.csproj::TargetFramework=net7.0-tizen]
C:\hostedtoolcache\windows\dotnet\packs\Samsung.Tizen.Sdk\7.0.114\targets\Samsung.Tizen.Sdk.Packaging.targets(161,5): error : Current target framework net7.0-tizen is not supported in this api-version. [D:\a\1\s\samples\CommunityToolkit.Maui.Sample\CommunityToolkit.Maui.Sample.csproj::TargetFramework=net7.0-tizen]

@JoonghyunCho
Copy link
Member

Hey @JoonghyunCho! We're seeing a Tizen error in the build. Could you take a look?

https://dev.azure.com/dotnet/CommunityToolkit/_build/results?buildId=94166&view=logs&j=67da6a11-18ef-5f70-9b43-fae7e6c83e18&t=49ed9970-d038-52c3-9405-25559677b293&l=575

C:\hostedtoolcache\windows\dotnet\packs\Samsung.Tizen.Sdk\7.0.114\targets\Samsung.Tizen.Sdk.Packaging.targets(161,5): error : The api-version specified in tizen-manifest file is 7. [D:\a\1\s\samples\CommunityToolkit.Maui.Sample\CommunityToolkit.Maui.Sample.csproj::TargetFramework=net7.0-tizen]

C:\hostedtoolcache\windows\dotnet\packs\Samsung.Tizen.Sdk\7.0.114\targets\Samsung.Tizen.Sdk.Packaging.targets(161,5): error : Current target framework net7.0-tizen is not supported in this api-version. [D:\a\1\s\samples\CommunityToolkit.Maui.Sample\CommunityToolkit.Maui.Sample.csproj::TargetFramework=net7.0-tizen]

Absolutely! Will take a look during the weekend or early next week :)

@brminnick brminnick enabled auto-merge (squash) July 10, 2023 17:08
pictos
pictos previously approved these changes Jul 10, 2023
Copy link
Member

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment, but nothing that would block you from merging this puppy (:

Copy link
Member

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brminnick brminnick merged commit 0b86ba1 into main Jul 10, 2023
7 checks passed
@brminnick brminnick deleted the Add-Popup.CloseAsync() branch July 10, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants