BadgeCounter #807 #1126
Merged
BadgeCounter #807 #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brminnick
requested changes
Apr 14, 2023
There was a problem hiding this comment.
Thanks Vlad!
Let's avoid adding a NuGet Dependency to CommunityToolkti.Maui.Core. Let's see if we can instead leverage that author's implementation.
I'd also like to rename the namespace to CommunityToolkit.Maui.ApplicationModel to align with .NET MAUI and rename the class to Badge so that we could add additional methods in the future (eg Clear()).
src/CommunityToolkit.Maui.Core/Essentials/BadgeCounter/IBadgeCounter.shared.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Essentials/BadgeCounter/IBadgeCounter.shared.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Essentials/BadgeCounter/BadgeCounterImplementation.android.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Essentials/BadgeCounter/BadgeCounterImplementation.android.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Essentials/BadgeCounter/BadgeCounter.shared.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Essentials/BadgeCounter/BadgeCounterImplementation.net.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Essentials/BadgeCounter/BadgeCounterImplementation.macios.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Essentials/BadgeCounter/BadgeCounterImplementation.android.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/CommunityToolkit.Maui.Core.csproj
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Essentials/BadgeCounter/BadgeCounter.shared.cs
Outdated
Show resolved
Hide resolved
ghost
added
stale
pictos
reviewed
May 29, 2023
VladislavAntonyuk
removed
help wanted
VladislavAntonyuk
force-pushed
the
badge-counter
branch
from
bae5569
to
a942925
Compare
VladislavAntonyuk
added
the
needs discussion
pictos
reviewed
Jun 16, 2023
samples/CommunityToolkit.Maui.Sample/Platforms/Android/MainApplication.cs
Outdated
Show resolved
Hide resolved
samples/CommunityToolkit.Maui.Sample/Platforms/Android/SamsungBadgeProvider.cs
Outdated
Show resolved
Hide resolved
samples/CommunityToolkit.Maui.Sample/Platforms/Android/SamsungBadgeProvider.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Essentials/Badge/Android/BadgeFactory.android.cs
Outdated
Show resolved
Hide resolved
pictos
reviewed
Jun 16, 2023
src/CommunityToolkit.Maui.Core/Essentials/Badge/Android/BadgeFactory.android.cs
Outdated
Show resolved
Hide resolved
VladislavAntonyuk
force-pushed
the
badge-counter
branch
from
2eff998
to
cd36f81
Compare
- Fix a typo in SamsungBadgeProvider.cs by changing "new[1]" to "new string[1]" - Add a new test method GetBadgeFailsOnNet() in BadgeTests.cs that tests the behavior of getting badge count on .NET platform - Modify the existing test method SetBadgeFailsOnNet() in BadgeTests.cs to throw NotSupportedException instead of NotImplementedException - Add a new method GetCount() in BadgeImplementationMock.cs that throws NotImplementedException
Sorry Vlad - this was my fault!
brminnick
requested changes
Jul 13, 2023
src/CommunityToolkit.Maui.Core/Essentials/Badge/BadgeImplementation.windows.cs
Outdated
Show resolved
Hide resolved
pictos
reviewed
Jul 13, 2023
src/CommunityToolkit.Maui.Core/Essentials/Badge/IBadge.shared.cs
Outdated
Show resolved
Hide resolved
pictos
reviewed
Jul 13, 2023
src/CommunityToolkit.Maui.Core/Essentials/Badge/BadgeImplementation.macios.cs
Outdated
Show resolved
Hide resolved
VladislavAntonyuk
force-pushed
the
badge-counter
branch
from
801f8f0
to
82b07d7
Compare
pictos
reviewed
Jul 14, 2023
src/CommunityToolkit.Maui.Core/Essentials/Badge/Android/BadgeFactory.android.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Essentials/Badge/Android/DefaultBadgeProvider.android.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Essentials/Badge/BadgeImplementation.tizen.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Essentials/Badge/BadgeImplementation.windows.cs
Outdated
Show resolved
Hide resolved
…ation.windows.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com>
…ation.tizen.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com>
…actory.android.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com>
…tBadgeProvider.android.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds Badge Counter
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information