[Proposal] AppIcon Badge #807
Assignees
Labels
approved
This Proposal has been approved and is ready to be added to the Toolkit
champion
A member of the .NET MAUI Toolkit core team has chosen to champion this feature
documentation approved
proposal
A fully fleshed out proposal describing a new feature in syntactic and semantic detail
Projects
Comments
VladislavAntonyuk
added
new
proposal
brminnick
moved this from Proposal Submitted
to Proposal Championed
in New Feature Proposals
ghost
added
champion
|
Thanks @VladislavAntonyuk! Promoting to
approved
Technically, we should've opened the Proposal first before voting to approve said Proposal, but we'll let this one slide. Submitting a Proposal doesn't require a vote from the core maintainers. It should start as a Discussion, and then once the Discussion is deemed feature-complete a Proposal can be opened. |
brminnick
moved this from Proposal Championed
to Proposal Approved
in New Feature Proposals
ghost
added
approved
|
I love this porposal =) |
|
@KSemenenko we are focusing on bug fixes for the next month or two. however I am going to implement it as a next feature PR. |
brminnick
added a commit
that referenced
this issue
Jul 23, 2023
* BadgeCounter #807 * Rename to Badge * Update tests * Remove Xamarin.Android.ShortcutBadger dependency * Fix Tizen build * Add default badge provider, add nova * Fix SamsungBadgeProvider * SetProvider * Initialize array only once * `dotnet format` * Update SamsungBadgeProvider.cs * Update BadgeViewModel.cs * Update DefaultBadgeProvider.android.cs * Use `Lazy<T>` to ensure thread safety * GetCount - Uncommented lines in the csproj file to address Android App installation failure. Toggle Home Screen Icon Badge Count - Added column and row spacing to improve layout in the BadgePage.xaml file. SetBadgeProvider method update - Renamed SetProvider method to SetBadgeProvider in the BadgeFactory.android.cs file. GetCount method implementation - Implemented GetCount method in the BadgeImplementation.android.cs, DefaultBadgeProvider.android.cs, BadgeImplementation.macios.cs, and BadgeImplementation.tizen.cs files. Added GetCount method to IBadge interface - Added GetCount method to the IBadge.shared.cs file. * feat: Add support for Samsung badge provider This commit adds support for the Samsung badge provider in the Android platform. It includes changes to the `SamsungBadgeProvider` class and the `DefaultBadgeProvider.android.cs` file. - Added a new static readonly string array `packageNameArray` in the `SamsungBadgeProvider` class. - Modified the `SetCount` method in the `SamsungBadgeProvider` class to use `packageNameArray` instead of directly passing a string array. - Added a new method `GetCount()` in the `SamsungBadgeProvider` class. - Renamed the method `IsSupported()` to `CanSetBadgeCounter()` in the `DefaultBadgeProvider.android.cs` file. - Added debug log statements for error handling scenarios in both classes. * Fix SamsungBadgeProvider.cs and BadgeTests.cs - Fix a typo in SamsungBadgeProvider.cs by changing "new[1]" to "new string[1]" - Add a new test method GetBadgeFailsOnNet() in BadgeTests.cs that tests the behavior of getting badge count on .NET platform - Modify the existing test method SetBadgeFailsOnNet() in BadgeTests.cs to throw NotSupportedException instead of NotImplementedException - Add a new method GetCount() in BadgeImplementationMock.cs that throws NotImplementedException * Fix build error Sorry Vlad - this was my fault! * Update CommunityToolkit.Maui.Sample.csproj * Update DefaultBadgeProvider.android.cs * Update BadgeImplementation.macios.cs * Update EssentialsGalleryViewModel.cs * Update BaseGalleryViewModel.cs * Update MainApplication.cs * Add null check * Remove `count` field * Update DefaultBadgeProvider.android.cs * Add additional text explaining Bade * Remove GetCount, use uint instead of int * fix tizen build * Update src/CommunityToolkit.Maui.Core/Essentials/Badge/BadgeImplementation.windows.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * Update src/CommunityToolkit.Maui.Core/Essentials/Badge/BadgeImplementation.tizen.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * Update src/CommunityToolkit.Maui.Core/Essentials/Badge/Android/BadgeFactory.android.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> * Update src/CommunityToolkit.Maui.Core/Essentials/Badge/Android/DefaultBadgeProvider.android.cs Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com> --------- Co-authored-by: Brandon Minnick <13558917+brminnick@users.noreply.github.com> Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com>
ghost
reopened this
|
Reopening Proposal. Only Proposals moved to the |
brminnick
moved this from Proposal Approved
to Pull Request Approved (Pending Documentation)
in New Feature Proposals
brminnick
removed
the
help wanted
brminnick
moved this from Pull Request Approved (Pending Documentation)
to Documentation Approved
in New Feature Proposals
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature name
AppIconBadge
Link to discussion
#734
Progress tracker
Summary
Notify the user about some action in the application.
Step by step with output screenshots at https://vladislavantonyuk.azurewebsites.net/articles/AppIcon-Badge-with-.NET-MAUI
Motivation
Better user experience and app interaction with OS.
https://developer.apple.com/documentation/uikit/uiapplication/1622918-applicationiconbadgenumber
https://github.com/leolin310148/ShortcutBadger
Detailed Design
Usage Syntax
var isGranted = await NotificationCounter.Default.RequestPermission(); if (isGranted) NotificationCounter.Default.SetNotificationCount(count);Drawbacks
Android implementation requires the support of many launchers. As part of this feature, I suggest creating a base class and implementation for some main providers, because we can't support all launchers
Alternatives
No response
Unresolved Questions
No response
The text was updated successfully, but these errors were encountered: