Skip to content

Commit

Permalink
[yarn] Bump sqlite3 to version with prebuilt aarch64 binaries
Browse files Browse the repository at this point in the history
Summary:
`@redux-devtools/cli` is dependent on the `sqlite3` node package (https://github.com/TryGhost/node-sqlite3). There previously weren't aarch64 binaries available, so `sqlite3` had to be built from scratch which made `yarn cleaninstall` take a while.

They recently added prebuilt binaries (TryGhost/node-sqlite3#1594), so we should bump the version to take advantage of this.

On my machine this took `yarn cleaninstall` from ~90 seconds to under a minute (~58 seconds).

Test Plan:
Read through release notes and things should continue to work as expected.

NOTE: This is unrelated to the SQLite client DB we use in the `native` app. This SQLite is solely to power Redux dev tools (which still work as expected).

Reviewers: tomek, marcin, ginsu, rohan, varun, ashoat

Reviewed By: ashoat

Subscribers: abosh

Differential Revision: https://phab.comm.dev/D5385
  • Loading branch information
atulsmadhugiri committed Oct 18, 2022
1 parent e7cb15a commit bf99526
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions yarn.lock
Expand Up @@ -17886,9 +17886,9 @@ sql-template-strings@^2.2.2:
integrity sha1-PxFQiiWt384hejBCqdMAwxk7lv8=

sqlite3@^5.0.2:
version "5.0.8"
resolved "https://registry.yarnpkg.com/sqlite3/-/sqlite3-5.0.8.tgz#b4b7eab7156debec80866ef492e01165b4688272"
integrity sha512-f2ACsbSyb2D1qFFcqIXPfFscLtPVOWJr5GmUzYxf4W+0qelu5MWrR+FAQE1d5IUArEltBrzSDxDORG8P/IkqyQ==
version "5.1.2"
resolved "https://registry.yarnpkg.com/sqlite3/-/sqlite3-5.1.2.tgz#f50d5b1482b6972fb650daf6f718e6507c6cfb0f"
integrity sha512-D0Reg6pRWAFXFUnZKsszCI67tthFD8fGPewRddDCX6w4cYwz3MbvuwRICbL+YQjBAh9zbw+lJ/V9oC8nG5j6eg==
dependencies:
"@mapbox/node-pre-gyp" "^1.0.0"
node-addon-api "^4.2.0"
Expand Down

0 comments on commit bf99526

Please sign in to comment.