Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(CI): unpin rubocop gem #1858

Merged
merged 1 commit into from
Apr 10, 2024
Merged

chore(CI): unpin rubocop gem #1858

merged 1 commit into from
Apr 10, 2024

Conversation

JanCBrammer
Copy link
Collaborator

A rubocop error breaks the linting job in our CI since version 1.63.
An upcoming release is (hopefully) fixing the error: rubocop/rubocop#12823.

This PR doesn't directly address the error. I just noticed and removed the (ineffective and obsolete) pinning of rubocop while I was investigating the CI failure.

Note that the removed comment refers to another, unrelated rubocop problem (with version 1.38).

@github-actions GitHub Actions
Copy link

LCOV of commit 6aed7f2 during Continuous Integration #2660

Summary coverage rate:
  lines......: 63.6% (13373 of 21028 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@soerenPeters soerenPeters self-assigned this Apr 10, 2024
@PiTrem PiTrem merged commit 0fe7bf2 into main Apr 10, 2024
3 checks passed
@JanCBrammer JanCBrammer deleted the ci-pronto branch April 10, 2024 15:30
PiTrem added a commit that referenced this pull request Apr 15, 2024
@PiTrem
TPA-mix
0267bb3 
Squashed commit of the following:

commit 7f44b473992a1d511f21ea1b994f8be29fac676b
Author: Fabian Mauz <fmauz@ipb-halle.de>
Date:   Fri Apr 12 13:58:08 2024 +0200

    fix: empty default cell-line collection in structure search result (#1871)

commit fbe156e98a31b4297ddcb0efbe2121ec9ac900e4
Author: TasnimMehzabin <TasnimMehzabin@users.noreply.github.com>
Date:   Fri Apr 12 09:03:19 2024 +0200

    fix(UI): attachment list disappearing from Inbox-device when toggling sorting (#1869)

    Co-authored-by: Tasnim Mehzabin <tasnim.mehzabin@live.com>

commit 31a9e4d9651d609b38991e1b7207c31a9d1ca182
Author: TasnimMehzabin <TasnimMehzabin@users.noreply.github.com>
Date:   Thu Apr 11 16:49:54 2024 +0200

    fix: multiple API calls inbox/container on deviceBox click (#1867)

    * fix: multiple API calls for empty device-Box

    * fix: the container/dataset fetch API redundant requests being made for each click on deviceBox (#1856)

    Co-authored-by: Tasnim Mehzabin <tasnim.mehzabin@live.com>

commit f0fde2a0e9881d6620dbfe29c7d2443c828d88a9
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Apr 10 16:49:58 2024 +0200

    chore: Bump tar from 6.1.11 to 6.2.1 (#1859)

    Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.11 to 6.2.1.
    - [Release notes](https://github.com/isaacs/node-tar/releases)
    - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/isaacs/node-tar/compare/v6.1.11...v6.2.1)

    ---
    updated-dependencies:
    - dependency-name: tar
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit d7e4928b67097c53c53f4d269db2802aa6441c4a
Author: Mostafa Mekky <59936007+mekkyz@users.noreply.github.com>
Date:   Wed Apr 10 16:49:27 2024 +0200

    fix(UI): sample entry alignment and spacing (#1853)

commit 0fe7bf26de3956f4797123f0c077efb42f3bfd89
Author: Jan C. Brammer <jan.c.brammer@gmail.com>
Date:   Wed Apr 10 16:04:04 2024 +0200

    ci: unpin rubocop version for pronto(#1858)

commit 4e917afd9731a26164cd98a5d27e8dd92eeb93dd
Author: Pei Chi Huang <pei-chi.huang@kit.edu>
Date:   Mon Apr 8 12:04:18 2024 +0200

    chore: change rinchi-gem to github (#1854)

commit f3cf95fd8ac94b5c342c9add182063975dbf7341
Author: Lan Le <baolan2005@gmail.com>
Date:   Fri Apr 5 12:45:42 2024 +0200

    fix: NMRium button disabled on 2D NMR (#1848)

    Co-authored-by: Lan Le <lan.le@kit.edu>

commit edfd5ece174623ddb10cbd1d41899c40d19d5943
Author: Mehreen Mansur <mehreen.mansur@gmail.com>
Date:   Fri Apr 5 09:13:04 2024 +0200

    fix: no default value for analysis name (#1846)

commit 8933fe2eea21e39c0c278b0c7783b462a53f2747
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Thu Mar 28 20:28:58 2024 +0100

    chore: prepare v1.9.0 tag (#1844)

commit a714b63f68f22e053aa76fc7b45ac4fc2bd95c5e
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Thu Mar 28 17:55:28 2024 +0100

    chore: default ketcher2 configs in UI Feature (#1843)

    - The default editor id for ketcher2 config is missing. Although the ELN Admin can set it, this migration set the default value.

    NB: a missing or wrong `editor` value will prevent the option to show up in the Structure Editor Modal

    - Also updated the yml example file on pair with the doc (https://github.com/ComPlat/chemotion_saurus/pull/321)

commit 3c2acc158dc7ef5e7bcd2963623104c32128bff7
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Thu Mar 28 17:34:47 2024 +0100

    fix: import collection export zip when directory entries present (#1841)

    * test: test import with modified zip (missing schema.json, rezipped)

    * fix: skip directory entries when parsing import collection zip

commit cca1122bb463227e2a4bb60ba256d726af5b5aae
Author: Adam Basha <55552142+adambasha0@users.noreply.github.com>
Date:   Thu Mar 28 17:09:41 2024 +0100

    fix: handle sample xref properties when xref is null (#1842)

commit 84c88065cfd0f4434942308ce3f380f591763004
Author: TasnimMehzabin <TasnimMehzabin@users.noreply.github.com>
Date:   Thu Mar 28 15:31:14 2024 +0100

    fix: avoid multiple API calls to load the inbox when datasets/attachments are deleted (#1839)

    add the bulk delete API endpoint for attachments
    error message is logged into the Rails log

    Co-authored-by: Tasnim Mehzabin <tasnim.mehzabin@live.com>

commit 38b0d84d0c764188475ab1cbeef56ab83d526ec8
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Mar 28 08:30:43 2024 +0100

    chore: Bump express from 4.17.3 to 4.19.2 (#1840)

    Bumps [express](https://github.com/expressjs/express) from 4.17.3 to 4.19.2.
    - [Release notes](https://github.com/expressjs/express/releases)
    - [Changelog](https://github.com/expressjs/express/blob/master/History.md)
    - [Commits](https://github.com/expressjs/express/compare/4.17.3...4.19.2)

    ---
    updated-dependencies:
    - dependency-name: express
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 7dd501f0b199820c8b622d30b20ac666e13a57ed
Author: Mehreen Mansur <mehreen.mansur@gmail.com>
Date:   Wed Mar 27 13:16:46 2024 +0100

    fix: updated volume ratio calculation of purification solvents on save (#1833)

commit adc0eaa67485d2a25127cb599f1b2667db2b0daf
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Wed Mar 27 13:08:14 2024 +0100

    refactor: handle quill to plain text conversion asynchronously (#1838)

    in Reaction (description, observation) and Container (extended_metadata) for better performance on save

    TODO: use a more efficient converter

commit 5b23de8a10c47e50f7d807a09f21be01b2eedd9a
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Wed Mar 27 13:05:28 2024 +0100

    fix: docx report of sample without reaction: refactor safe navigation (#1835)

commit 1fe589a859078084c9d9001ecf30d24bb6186f94
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Wed Mar 27 07:59:24 2024 +0100

    test: fix use of defunct function (#1837)

    also disable faulty jcamp tests

commit 7584fef1a53d6a18983bbe41e2c3007918e47ccd
Author: Mehreen Mansur <mehreen.mansur@gmail.com>
Date:   Tue Mar 26 11:23:38 2024 +0100

    feat: Copy research plan  (#1667)

    * add copy research plan feature

    * create new derivatives for copy research plan

    * update copied annonated file

    * update identifier in copied research plan body

    * update copy attachment method

    ---------

    Co-authored-by: Mehreen <mehreen.mansur>

commit 2e63c066285927dcb62c253b830f19b3532c25c4
Author: Adam Basha <55552142+adambasha0@users.noreply.github.com>
Date:   Tue Mar 26 08:57:33 2024 +0100

    fix: safety sheets are not imported and significantly slow down the import (#1779)

    * define timeout for safety data sheet requests

    * modify header for safety data sheet merck request and improve product number extraction

    * fix regex for extracting merck product number

    * add sleep time between fetch sds merck api requests

    * fix: handle empty safety phrases objects in chemicalTab component

    * refactor: remove check_if_safety_sheet_already_saved function in chemicalsService class

commit a6fea72a2e6d3a050a3c54e7a5255dbced60058b
Author: Jan C. Brammer <jan.c.brammer@gmail.com>
Date:   Mon Mar 25 17:31:25 2024 +0100

    feat(UI): Add column header menus to `ReactionVariations` table (#1804)

    * Ensure auto-sizing doesn't hide tool cell

    * Uniformly set non-existing values to `null`

    * Add column header menu

    - select unit per column (instead of per cell)
    - select name per material (instead of selecting uniform name category for all materials)
    - select editable quantity per column (instead of having all quantities editable per cell)

    * Increase test coverage for `ReactionVariationsUtils.js`

    Raise function- and statement coverage to 100%.

    * Add prop types

    * Remove superfluous check for empty variations

commit df397eca88f77cf00964911c2a7e5487fe2f8bae
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Mar 25 14:55:24 2024 +0100

    chore: Bump webpack-dev-middleware from 5.3.1 to 5.3.4 (#1829)

    Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.1 to 5.3.4.
    - [Release notes](https://github.com/webpack/webpack-dev-middleware/releases)
    - [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md)
    - [Commits](https://github.com/webpack/webpack-dev-middleware/compare/v5.3.1...v5.3.4)

    ---
    updated-dependencies:
    - dependency-name: webpack-dev-middleware
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 5ccb270100056c1db39905cf3d87eac7a1dd3bf4
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Mon Mar 25 14:46:15 2024 +0100

    refactor: svg scrubber (#1830)

    * refactor: svg scrubber dry

     * fix:  Loofah strips css rgb function when not in a `style` attribute
    this leads to tags from ketcher 2.18 SVG to not show up : eg `<path stroke="rgb(....)" /> `becomes `<path />`
    Implement global replacement of rgb function values to black  hex `#000000`

commit 25933203cf9e6f582aaf617718c3438297c93122
Author: Ashwini <amurthy.ashwini@gmail.com>
Date:   Mon Mar 25 09:11:40 2024 +0100

    fix: delete user account without confirmation (#1828)

commit 7fdec1e2561a674e4224069a9fb0496c8f0a510d
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Thu Mar 21 17:23:01 2024 +0100

    chore: ruby nodjs  minor update  (#1812)

    * chore: bump nodejs minor version and ruby patch version

    * chore: npx yarn-audit-fix

    * chore: nokogiri upd

commit c1c81f217f0b926ad9f26504b30130c3cc06fd55
Author: Adam Basha <55552142+adambasha0@users.noreply.github.com>
Date:   Thu Mar 21 12:47:02 2024 +0100

    feat: save button for chemical inventory in sample header (#1810)

    * feat: option save button for inventory tab in sample header

    * feat: add functionality for save button in sample header to save chemical in inventory tab

    * refactor spec tests for chemicalFactory & chemicalTab

    * add updateCheckSum to handleSubmitSave a chemical to synchronize changes to checksum after saving

    * refactor: adjust spacing between box elements in sample header

commit f93105171c37d2d5d2cbf1c49b69d7761e607184
Author: Fabian Mauz <fmauz@ipb-halle.de>
Date:   Fri Mar 15 13:13:32 2024 +0100

    fix: advanced search for reaction temperature or time (#1816)

    * test: add failing test for issue with advanced search and corrupted data

    * fix: add a case statement into sql builder to handle corrupted data

    * refactor: sharpend regEx expression and did some extraction

    * refactor: refactored condition for duration in advanced search

    * fix: fixed issue with advanced search if no valid number is given in datafield

commit 0c3d126651292d09e2be884d85348e4454b4d3d9
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Mar 8 08:42:24 2024 +0100

    chore: Bump yard from 0.9.35 to 0.9.36 (#1800)

    Bumps [yard](https://github.com/lsegal/yard) from 0.9.35 to 0.9.36.
    - [Release notes](https://github.com/lsegal/yard/releases)
    - [Changelog](https://github.com/lsegal/yard/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/lsegal/yard/compare/v0.9.35...v0.9.36)

    ---
    updated-dependencies:
    - dependency-name: yard
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 6218479967cf1380a7d4415e56f29fa09c3ae604
Author: Mehreen Mansur <mehreen.mansur@gmail.com>
Date:   Fri Mar 8 08:41:53 2024 +0100

    fix: disabled create button for synced collection (#1811)

    * update create button condition for sync collection

    * display create element list as per sorted layout (resolved #1793)

commit a9a168602129a4537c127433468a61a656639947
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Mar 6 15:17:05 2024 +0100

    chore: Bump rails from 6.1.7.6 to 6.1.7.7 (#1787)

    Bumps [rails](https://github.com/rails/rails) from 6.1.7.6 to 6.1.7.7.
    - [Release notes](https://github.com/rails/rails/releases)
    - [Commits](https://github.com/rails/rails/compare/v6.1.7.6...v6.1.7.7)

    ---
    updated-dependencies:
    - dependency-name: rails
      dependency-type: direct:production
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit ebc41c9d2c65560c3ab4e3b893ab07edaaef479e
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Mar 6 15:16:21 2024 +0100

    chore: Bump json-jwt from 1.16.1 to 1.16.6 (#1802)

    Bumps [json-jwt](https://github.com/nov/json-jwt) from 1.16.1 to 1.16.6.
    - [Release notes](https://github.com/nov/json-jwt/releases)
    - [Changelog](https://github.com/nov/json-jwt/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/nov/json-jwt/compare/v1.16.1...v1.16.6)

    ---
    updated-dependencies:
    - dependency-name: json-jwt
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 309d6949685117c12d91307b6f0ae4a7e86f6cc8
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Wed Mar 6 14:05:02 2024 +0100

    refactor: react-dnd target for Dataset component (#1795)

    * refactor: DRY react-dnd for 2 targets

     (fix renderOverlay not a function)

commit 753acf0ab9bd44003664ee82240248bbe547e8bc
Author: Lan Le <baolan2005@gmail.com>
Date:   Tue Mar 5 22:17:36 2024 +0100

    fix: save correct combined image (#1772)

    Co-authored-by: Lan Le <lan.le@kit.edu>

commit 231d7f857396e24955a05b29d3fcf2cc86552caf
Author: Lan Le <baolan2005@gmail.com>
Date:   Mon Mar 4 09:21:54 2024 +0100

    fix: open NMRium with upload peak.jdx file(#1789)

    bump version of spectra-app
    Co-authored-by: Lan Le <lan.le@kit.edu>

commit 6e939b3cc86fb6875636526346441803b04921f0
Author: Lan Le <baolan2005@gmail.com>
Date:   Fri Mar 1 14:06:13 2024 +0100

    refactor: display the latest edited file on chemspectra (#1778)

    Co-authored-by: Lan Le <lan.le@kit.edu>

commit 58710bf9b7de182082eb0aebcf7cfc074090b402
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Mar 1 14:04:53 2024 +0100

    chore: Bump yard from 0.9.28 to 0.9.35 (#1791)

    Bumps [yard](https://github.com/lsegal/yard) from 0.9.28 to 0.9.35.
    - [Release notes](https://github.com/lsegal/yard/releases)
    - [Changelog](https://github.com/lsegal/yard/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/lsegal/yard/compare/v0.9.28...v0.9.35)

    ---
    updated-dependencies:
    - dependency-name: yard
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 483a689ea56558a44928ae5acc53133dad35f0a7
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Mar 1 14:04:37 2024 +0100

    chore: Bump rack from 2.2.8 to 2.2.8.1 (#1792)

    Bumps [rack](https://github.com/rack/rack) from 2.2.8 to 2.2.8.1.
    - [Release notes](https://github.com/rack/rack/releases)
    - [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/rack/rack/compare/v2.2.8...v2.2.8.1)

    ---
    updated-dependencies:
    - dependency-name: rack
      dependency-type: direct:production
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 8db5fca61863eb83e5443e7af96bf4c8dcd41d4d
Author: Jan C. Brammer <jan.c.brammer@gmail.com>
Date:   Tue Feb 27 14:12:38 2024 +0100

    fix(UI): Adapt row height to SVG (#1782)

commit 7e23cb1c465faf03c4df80a6eb05a8b1728c7cb9
Author: Jan C. Brammer <jan.c.brammer@gmail.com>
Date:   Tue Feb 27 14:12:12 2024 +0100

    fix(devcontainer): Make script executable (#1784)

commit de2b3e0ba3a9bca3fd1e864118f7e9a90bd85329
Author: Adam Basha <55552142+adambasha0@users.noreply.github.com>
Date:   Tue Feb 27 08:52:01 2024 +0100

    feat: allow import of sample external label on sample import (#1767)

    * allow import of sample external label on sample import

    * disable search for SDS using thermofischer option in inventory tab

commit e08539c4b77ba02c0674fbeb6fc0fc431ef9874c
Author: Mehreen Mansur <mehreen.mansur@gmail.com>
Date:   Tue Feb 27 08:49:56 2024 +0100

    fix: thumbnail load issue in Preview page (#1754)

    * fix thumbnail preview issues
    fix typos

    * serialize thumbnail for report preview

    * do not encode thumbnail if it cannot be read

    ---------

    Co-authored-by: PiTrem <pierre.tremouilhac@kit.edu>

commit 1a6cfea9d1c450b91e0aa2223427e333e7ea70b1
Author: Mehreen Mansur <mehreen.mansur@gmail.com>
Date:   Mon Feb 26 16:00:24 2024 +0100

    fix: si spectra report generation for reaction with multiple products (#1777)

commit e61e6270a01625273a3304c48109ffddbaeb4879
Author: Sören Peters <soerenPeters@users.noreply.github.com>
Date:   Wed Feb 21 15:52:00 2024 +0100

    fix: dev-container setup (#1771)

    * fix: webpacker container startup

    Enable clean webpacker startup by ensuring intended startup order of containers.

    * fix: devcontainer

    With https://github.com/ComPlat/chemotion_ELN/pull/1665 the node installation is moved from `Dockerfile.chemotion-dev` to `run-ruby-dev.sh`, which is not executed by the devcontainer. That's why the devcontainer would not start. Running `run-ruby-dev.sh` as part of the devcontainer startup would introduce a lifetime depdendency from the rails server (running in the `app` container) to the devcontainer. This is why we extracted the installation of node into a new script, which is now called from `run-ruby-dev.sh` as well as `postCreateCommand` command in devcontainer.

    * Don't start `webpacker` before all gems are installed in `app`

    ---------

    Co-authored-by: Sören Peters <dev.peters@icloud.com>
    Co-authored-by: Jan C. Brammer <jan.c.brammer@gmail.com>

commit 975669fa4f0aacad89f2c563a366921322a7760b
Author: Mehreen Mansur <mehreen.mansur@gmail.com>
Date:   Wed Feb 21 15:37:24 2024 +0100

    fix: Quill editor menu bar for admin text template (#1765)

    * add special character and sup/sub-script option to Quill-editor in Admin text template UI

    * update text template seed data for HR-EI and HR-FAB

commit 1cc1c0fb32f9734dc66040c6bfb609035e86052e
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Mon Feb 19 18:10:34 2024 +0100

    refactor: rb quill delta converter (#1757)

    - quill convert as class method

    - prevent spawning node process if ops is blank

    - option to filter image insert from ops

    - pass input as file if too large (`Errno::E2BIG (Argument list too long)`)

    - filter empty inserts from string input to avoid conversion to fail

    - force gc on migrations that uses the quill-converter to avoid accumulation of node processes

    chore: revert nokogiri upd ( ruby version requirement )

commit 9c81127f4ec9492577b1fc59eb41fdb360c71263
Author: Pei Chi Huang <pei-chi.huang@kit.edu>
Date:   Fri Feb 16 10:19:25 2024 +0100

    fix:generic dataset general info for CV (#1762)

    Co-authored-by: Chia-Lin Lin <chia-lin.lin@kit.edu>

commit 95bd376d626bc84d112a0d2682986068a3161326
Author: TasnimMehzabin <TasnimMehzabin@users.noreply.github.com>
Date:   Thu Feb 8 13:28:19 2024 +0100

    feat: data collector mechanism is modified to collect files/folders from user-level directories (#1728)

    make the input field readonly in the admin panel, when user level data collection is selected

    Co-authored-by: Tasnim Mehzabin <tasnim.mehzabin@live.com>

commit 9e985ceacb77da4b916205e13fd17fce5635ffd5
Author: f-idiris <112618970+f-idiris@users.noreply.github.com>
Date:   Thu Feb 8 08:48:00 2024 +0100

    chore: update react spectra editor to v1.2.0 (#1730)

    * fix: C13 nmr solvent shift in 2 decimal places

    * upd: react-spectra-editor and spectra client v1.2.0

commit 32f73d962d442bd4f16ba0a9b7472e42d70e7207
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Feb 7 10:57:38 2024 +0100

    chore: Bump nokogiri from 1.15.5 to 1.16.2 (#1729)

    Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.15.5 to 1.16.2.
    - [Release notes](https://github.com/sparklemotion/nokogiri/releases)
    - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.15.5...v1.16.2)

    ---
    updated-dependencies:
    - dependency-name: nokogiri
      dependency-type: direct:production
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 76747624dc1a75a9df634487166f9e75c1837fcc
Author: TasnimMehzabin <TasnimMehzabin@users.noreply.github.com>
Date:   Wed Feb 7 10:57:04 2024 +0100

    fix: avoid loading the comments if the user does not have UI permission for comments (#1727)

    fix bullet eager loading warnings

    Co-authored-by: Tasnim Mehzabin <tasnim.mehzabin@live.com>

commit 4df85fd34bf49a714a32e402dea001589e0fb79d
Author: Fabian Mauz <fmauz@ipb-halle.de>
Date:   Wed Feb 7 09:31:46 2024 +0100

    fix: advanced search not working - cell-line (#1733)

    * fix: add artificial empty cell line search result to advanced search

    * style: fix rubocop warnings

    * TODO re-implement cell-line search

commit 26e79fb85eed699b6dee6e225a0ea33356f871dc
Author: f-idiris <112618970+f-idiris@users.noreply.github.com>
Date:   Tue Feb 6 13:32:25 2024 +0100

    fix: nmr prediction freezes (#1720)

commit d7d392059468744bad4f155e8f84877ed2d3e43d
Author: Jan C. Brammer <jan.c.brammer@gmail.com>
Date:   Tue Feb 6 13:31:19 2024 +0100

    fix(UI): cosmetic update of reaction-variations table (#1719)

    * Always show horizontal scrollbar

    * Fit column width to content

    * Set numerical precision to 4 significant digits

commit 8bb37efe5fcba00d4f0f7866100a29d19b6daece
Author: Jan C. Brammer <jan.c.brammer@gmail.com>
Date:   Tue Feb 6 13:29:40 2024 +0100

    chore: update ag-grid (#1714)

commit 97cf66f0ecd7427a4960d6b2d5c078a5a3e3b6e0
Author: Mehreen Mansur <mehreen.mansur@gmail.com>
Date:   Thu Feb 1 15:21:06 2024 +0100

    fix: export research plan error on docx format (#1718)

    arg not accepted since gem upd  (ComPlat/chemotion_ELN@f0d6f7b)

    also fix error on table input

commit d78f48e89cc94cdd20c88f4bc47a347e46c8b094
Author: Mehreen Mansur <mehreen.mansur@gmail.com>
Date:   Thu Feb 1 11:28:37 2024 +0100

    feat: add helpdesk link in header (#1713)

commit 6a6c3aa6a16a849ed0fd748df704f3b814df4fb4
Author: f-idiris <112618970+f-idiris@users.noreply.github.com>
Date:   Thu Feb 1 11:08:29 2024 +0100

    fix: nmrium  missing 'close with save' button  in research plan

    Refs: #1715

commit 8a257e2489a230406c57bf82faab347465c61d31
Author: Adam Basha <55552142+adambasha0@users.noreply.github.com>
Date:   Thu Feb 1 11:07:07 2024 +0100

    fix: focus lost on input bug for melting & boiling points fields

    Refs: #1716

commit dc3203f04edfd2eb565ac9ba836aba70afa719cd
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Wed Jan 31 15:08:22 2024 +0100

    fix: dfg logo resource in README.md (#1710)

    * fix: dfg logo resource in README.md

    * Update README.md

commit 3097ba2006352109b247d6301ae8a2258060cc15
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Wed Jan 31 13:28:09 2024 +0100

    feat: Inbox device folders named with the device fullname

    (previously only firstname was used)

    db migration to rename Inbox-device folders

    Refs:  #1709

commit 1f3d0b52353eb4a2f0cbf7c4c51ddd1eceb6e067
Author: Pei Chi Huang <pei-chi.huang@kit.edu>
Date:   Wed Jan 31 12:13:53 2024 +0100

    feat: filter jdx files to be processed by converter-app

    prevent chemspectra generated jdx files to be processed by chemotion-converter-app jdx reader

    Co-authored-by: Chia-Lin Lin <chia-lin.lin@kit.edu>

    Refs:  #1712

commit 5daa9eb5e84fa244e32de29615316739233f9724
Author: f-idiris <112618970+f-idiris@users.noreply.github.com>
Date:   Wed Jan 31 09:28:55 2024 +0100

    feat: enable nmrium in read only collection (#1708)

commit 587ee7e1248c10ea83a35bfb7a6c89eb3a75f32e
Author: Adam Basha <55552142+adambasha0@users.noreply.github.com>
Date:   Wed Jan 31 08:46:50 2024 +0100

    feat: input field  for general remarks on all sample analyses

    Refs: #1696

commit affe293585209b7ff0bdac024f2a4990a23e693b
Author: Pei Chi Huang <pei-chi.huang@kit.edu>
Date:   Tue Jan 30 16:46:19 2024 +0100

    fix: data cannot be removed from segment of element

    https://github.com/LabIMotion/labimotion/releases/tag/v1.1.2

    Co-authored-by: Chia-Lin Lin <chia-lin.lin@kit.edu>

    Refs: #1711

commit d6f881903c5300129b6a44dfbd7d41acce183b29
Author: f-idiris <112618970+f-idiris@users.noreply.github.com>
Date:   Tue Jan 30 16:22:56 2024 +0100

    feat: label detector in SEC spectra

    *  label detector in SEC spectra

    *  update chemspectra to v1.1.1

    Refs:  #1691

commit c83ed704d6eb3232bc0a841a91b69672e7256042
Author: Christian Buggle <Christian.buggle@web.de>
Date:   Tue Jan 30 08:39:41 2024 +0100

    feat: Add models VesselTemplate, Vessel, CollectionsVessel

    * Add models VesselTemplate, Vessel, CollectionsVessel, Minimal models as required as a common base for the upcoming ReactionProcessEditor and upcoming features in ELN

    * Add migration and models for VesselTemplates, Vessel, CollectionsVessel.

    * Add gem ‘shoulda-matchers’ in environment :test.

    * Add shared_example :acts_as_paranoid_soft_deletable_model, include in the specs of all affected models.

    * Enable extension `pg_crypto` in schema.rb as this should be there from earlier migration 20220712100010_add_segment_klass_identifier.rb.

    * Use well defined ORD constants for vessel_type, material_type.
    * Add created vessel to user’s collection.

    * Make idempotent, do not run if vessel name exists.

    * Add weight, barcode, qrcode to Vessels

    * Add weight_amount, weight_unit to VesselTemplate, delegate in Vessel.

    * seeds for VesselTemplates & Vessels

    ---------

    Co-authored-by: nh9378 <basha.adam@kit.edu>

    Refs: #1548

commit 318fd345d60a2d0419bcf0faf5c2ce058f4ad8af
Author: TasnimMehzabin <TasnimMehzabin@users.noreply.github.com>
Date:   Tue Jan 30 08:35:06 2024 +0100

    feat: sort the device list by name in command_n_control (#1707)

    Co-authored-by: Tasnim Mehzabin <tasnim.mehzabin@live.com>

commit 4ac32c73d2d004962afca7e4fe113ff12e667b9d
Author: Pei Chi Huang <pei-chi.huang@kit.edu>
Date:   Thu Jan 25 17:32:34 2024 +0100

    feat: upgrade converter to v1.2.0 (#1704)

commit 89db312b00f4e3cd3b532c2347411a220f2e56c5
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Jan 24 12:36:22 2024 +0100

    chore: Bump puma from 5.6.7 to 5.6.8 (#1679)

    Bumps [puma](https://github.com/puma/puma) from 5.6.7 to 5.6.8.
    - [Release notes](https://github.com/puma/puma/releases)
    - [Changelog](https://github.com/puma/puma/blob/master/History.md)
    - [Commits](https://github.com/puma/puma/compare/v5.6.7...v5.6.8)

    ---
    updated-dependencies:
    - dependency-name: puma
      dependency-type: direct:production
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit f0d6f7b90e114eb999d81918fa350ea65e9eaadd
Author: Christian Buggle <Christian.buggle@web.de>
Date:   Wed Jan 24 11:22:17 2024 +0100

    chore: missing constant MIME::Types

    * Fix missing constant MIME::Types

    * Add gem ‘mime-types’ to Gemfile:

     in preparation to  ketcherails update: latest ketcherrails which no longer carries a dependency to `paperclip ->  mime-types`.

    * patch farraday

    Refs: #1660

commit 29a861853b3313d096f46613f410bf9a76a65ad9
Author: Mostafa Mekky <59936007+mekkyz@users.noreply.github.com>
Date:   Wed Jan 24 10:30:07 2024 +0100

    fix(UI): sample entry label alignment (#1693)

commit d60d9f7958b14bca76266e763b94d8663c7e4e49
Author: Adam Basha <55552142+adambasha0@users.noreply.github.com>
Date:   Wed Jan 24 10:27:08 2024 +0100

    fix: amount change of a reaction product from the sample properties tab

    * fix: bug for amount change of a reaction product sample from sample properties tab, does not render the change in the reaction scheme after saving sample change

    * assignAmountType when sample benlongs to reaction

    Refs: #1692

commit 5eedcef0bafff684abda425d9a297beac5968bb1
Author: Lan Le <baolan2005@gmail.com>
Date:   Wed Jan 24 09:21:27 2024 +0100

    feat: update react-spectra-editor to display theoretical mass value

    Co-authored-by: Lan Le <lan.le@kit.edu>
    Refs: #1675, https://github.com/ComPlat/react-spectra-editor/pull/186

commit c69bbf00bb5a8c9bd6614eb979f1293a172ecbc8
Author: Jan C. Brammer <jan.c.brammer@gmail.com>
Date:   Wed Jan 24 09:03:36 2024 +0100

    feat: Add `variations` attribute to reaction report settings (#1697)

commit e51e89d8d3f960aee5bcfdc989cb061198063af3
Author: Adam Basha <55552142+adambasha0@users.noreply.github.com>
Date:   Tue Jan 23 08:56:54 2024 +0100

    feat: add sample inventory label counter

    add inventory model and inventory label feature

    Refs: #1581

commit dffea5bb8219ed49ce2c6cc4f2b82c5e1e1d28c1
Author: Jan C. Brammer <jan.c.brammer@gmail.com>
Date:   Tue Jan 23 08:52:55 2024 +0100

    refactor: extract` SpectraEditorButton` to dedicated component

    * Extract` SpectraEditorButton`  to dedicated component

    * Pass missing `element` parameter to `SpectraEditorButton`

    Refs: #1664

commit 41928e8fe5fbd4b62b169a31e63106c639682ea2
Author: Mostafa Mekky <59936007+mekkyz@users.noreply.github.com>
Date:   Tue Jan 23 08:51:29 2024 +0100

    feat: group analysis attachments

    attachments are grouped according to their original/processed status

    added better thumbnail preview

    Refs: #1674

commit f8362ac9aa69fc49f4a19ab8e8bd0f25e5ab6d57
Author: Jan C. Brammer <jan.c.brammer@gmail.com>
Date:   Tue Jan 23 08:48:39 2024 +0100

    fix(UI): show Tooltip on + button in reaction-variations tab (#1694)

commit 16f75929f91b3f233b4c3253db927ad7940eaef0
Author: Pei Chi Huang <pei-chi.huang@kit.edu>
Date:   Thu Jan 18 15:07:30 2024 +0100

    fix(int): zip upload

    Co-authored-by: Chia-Lin Lin <chia-lin.lin@kit.edu>

    Refs: #1690, #1688

commit 9a765180670bd9c737630ac31668786adf6026aa
Author: Lan Le <baolan2005@gmail.com>
Date:   Thu Jan 18 09:52:35 2024 +0100

    test: fix stub request in spectra jdx test

    Co-authored-by: Lan Le <lan.le@kit.edu>
    Refs: #1689, #1596

commit 1a93cf52ceac1eed19d2ffc50c62c4528531df0e
Author: Pei Chi Huang <pei-chi.huang@kit.edu>
Date:   Mon Jan 15 15:51:43 2024 +0100

    feat: converter metadata  added to dataset download (#1688)

    Dataset-xls improvement - more information is provided in the Description sheet.

    See the documentation https://www.chemotion.net/docs/labimotion/guides/user/datasets/download

    Co-authored-by: Chia-Lin Lin <chia-lin.lin@kit.edu>

commit 69ad0a9ad183a9d614489a1ea38a47f82895b6b1
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Mon Jan 15 13:13:29 2024 +0100

    refactor: dry schmooze tools (#1684)

    common input parser for quill-to-html and quill-to-plain-text

    now handle empty delta to prevent (db/migration) errors
    ```
         Schmooze::JavaScript::TypeError:
           only `insert` operations can be transformed!
    ```

commit 7097d40324fe40145ddaca8819e9e135b9eff236
Author: Lan Le <baolan2005@gmail.com>
Date:   Mon Jan 15 11:12:20 2024 +0100

    chore: update runner - fix text (#1683)

    * test: fix mock api for jcamp process

    * test: test rubocop action to use ruby  3.3

    * chore: npx browserslist@latest --update-db

    * chore: yarn-audit-fix

    * chore: upd gitignore

    * chore: update CHANGELOG v1.8.1

    * chore: update db/schema.rb

    ---------

    Co-authored-by: Lan Le <lan.le@kit.edu>
    Co-authored-by: PiTrem <pierre.tremouilhac@kit.edu>

commit 5bee5403e369abd63a2fcb64ff7e46dcef98a9fd
Author: Jan C. Brammer <jan.c.brammer@gmail.com>
Date:   Wed Jan 10 15:47:09 2024 +0100

    fix: temperature conversion in reaction

    Refs: #1680

commit 4c7b2ff43a2025c7a92f4319b3d1181366e94010
Author: Mostafa Mekky <59936007+mekkyz@users.noreply.github.com>
Date:   Wed Jan 10 15:45:24 2024 +0100

    fix: remove duplicate user label and center the share button (#1682)

commit 234fb88b0b6a28d7656b828ffa673764b18daf43
Author: Fabian Mauz <fmauz@ipb-halle.de>
Date:   Wed Jan 10 09:08:50 2024 +0100

    fix: tests for searching cell lines (#1678)

commit a0c1b34399cc31fccd0263d1c7d194fb8dad4189
Author: f-idiris <112618970+f-idiris@users.noreply.github.com>
Date:   Wed Jan 10 09:01:01 2024 +0100

    feat: Table of data types and chemspectra layouts in the ELN Admin

    * feat: Add chemspectra admin for updating data type

    * datatype list managed on the ELN with default values from chemspectra is passed to chemspectra as arg.

    Refs: #1574

commit f8edcd6a61cae163d04a129f91ffe76ca6dc4fa3
Author: Fabian Mauz <fmauz@ipb-halle.de>
Date:   Mon Jan 8 10:28:13 2024 +0100

    feat: add new element cell line

    cell-line as a stand-alone element :
    user can manage cell-line samples in their collections.

    add 2 models: CelllineSample and CelllineMaterial (belongs to CelllineSample)

    export/import collection  with cell-lines

    bioassay ontology  for cell line analysis

    search of cell line by material/sample name

    Refs: #1582

commit 0be3cd98440476b86db207021f5675f74da3ca60
Author: Beate Quednau <bq@megorei.com>
Date:   Fri Jan 5 15:20:40 2024 +0100

    feat: extend search

    * Add search modal

    * Add toggable panel for search and result at search modal forms

    * Add search result tab lists

    * Add search result tab content with pagination

    * Add advanced search form fields

    * Add element list filter to search result

    * Add handle safe for advanced search and ketcher

    * Add handle refind, adopt result

    * Add clear search and tab results, Set tab index for tab with results

    * Add order and group by molecule to search results

    * Clear search when clicking on collection

    * Add search by ids for search result tab pages

    * Add alert to remove search result

    * Add basic element selection for advanced search

    * Add search queries for reactions, wellplates and screens, and research plans

    * Add publication search

    * Add basics for generic element search

    * Add hr to generic element search for testing deployment

    * Add more search fields for reactions and screens

    * Add temperature and duration to reaction search fields

    * Add readout titles at wellplate search

    * Add quill to plain text and additional plain text field for description fields

    * Add description fields to search

    * Remove old advanced  and structure search, Remove old generic search, cleanup

    * Add use cases for advanced search, search by ids, structure search

    * Add input-group, formula, table fields to detail search

    * Add better error messages

    * Add search results store and simple search results

    * Simplify visibility of search modal with mobx store

    * Add plain text content to containers, refactore fieldsByTabs

    * Add solvent fields to sample search

    * Add unit tests for advanced, structure and by_ids search

    * Add cypress test and identificator for search modal

    * Add klasses.json to gitignore

    * Add more descriptions for readme-dev

    * Fix ketcher rails search

    * Fix advanced search with multi search fields

    * Fixes for generic elements

    * Fix base fetcher for generic elements

commit d7144d433d62287702f6bd83ae765a2f261d6b9f
Author: TasnimMehzabin <TasnimMehzabin@users.noreply.github.com>
Date:   Thu Dec 21 10:35:36 2023 +0100

    fix: attached research_plans in screens not being imported from collection

    * fix: attached research_plans in screens not being imported from collection
    wellplates not being imported from collection

    * style: rubocop

    ---------

    Co-authored-by: Tasnim Mehzabin <tasnim.mehzabin@live.com>
    Refs: #1671

commit cc3930d079d7e958f158edc860d0626df5876660
Author: Mostafa Mekky <59936007+mekkyz@users.noreply.github.com>
Date:   Wed Dec 20 11:36:15 2023 +0100

    feat: Unified attachment list

    enhancing attachment list:

    applying new attachment list to Datasets, research plan and well-plate attachments

    * feat: sorting feat by name, date ( hide sorting functions if no attachments)

    * enabling style prop on component

    * refactor: Dataset Modal Redesign

    * refactor: converting inline styles to scss

    * Style: cleaner code and linking to new css classes

    * dataset modal discarding logic

    * unifying edited image warning text

    * style: eslint fixes and css enhancements

    * feat: strike attachment name when deleted

    * Removed discard btn for 1.9.0

    ---------

    Refs: #1608

commit 324bc372f2acc34712a441ed045f4f3bda77994a
Author: Lan Le <baolan2005@gmail.com>
Date:   Wed Dec 20 10:53:30 2023 +0100

    fix: remove original data from nmrium data before storing it

    Co-authored-by: Lan Le <lan.le@kit.edu>
    Refs: #1661

commit 63c4e32e0441656081e13088be6ce63b5af101d0
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Wed Dec 20 06:21:01 2023 +0100

    fix: camelcasing attributes for proper display of SVGs

    * fix: camelcasing attributes for proper display of svgs

    due to the scrubber library lowercasing all attribute names some properties
    are not rendered in the browser.

    In this case beads with a gradient  in molecule, sample and reaction
    were not displayed in browser and were also missing after conversion in png in doc report.

    (successiv gsub benchmarked as faster than gsub with regex and a dict)

    * upd yarn.lock

    Refs:  #1670

commit 15768e0b30894011397285e350bcd3ad4c8bf902
Author: Lan Le <baolan2005@gmail.com>
Date:   Wed Dec 20 06:00:40 2023 +0100

    feat: add chemspectra with ref peaks (#1596)

    Co-authored-by: Lan Le <lan.le@kit.edu>

commit 589e8b8bc46bc1d17c19f2af978b5368dcef0ad5
Author: Lan Le <baolan2005@gmail.com>
Date:   Wed Dec 20 05:52:53 2023 +0100

    fix(spectra): react-spectra-editor upd to correct molecule display with svg zoom pan

    Co-authored-by: Lan Le <lan.le@kit.edu>

    Refs: #1656, https://github.com/ComPlat/react-svg-file-zoom-pan/pull/44

commit df1a75b92b4f2ad3786a63810720dc81f152d080
Author: Johannes Haubold <jh@megorei.com>
Date:   Wed Dec 13 12:36:05 2023 +0100

    chore: Improve Dev Setup by autorecognizing the installed tool versions (#1665)

commit a1fdf19339ff1583779152af3e9f641b666e4452
Author: Mostafa Mekky <59936007+mekkyz@users.noreply.github.com>
Date:   Tue Dec 12 08:21:01 2023 +0100

    fix(UX): molecule title layout and element table header responsiveness

    * spacing at sample header

    * responsive element table header

    *  eslint

    * remove gray color

    * remove unneeded margin right

    Refs: #1650, #1646

commit 1d259fadb8a17f34087dcc131adc774959a212c8
Author: Mehreen Mansur <mehreen.mansur@gmail.com>
Date:   Tue Dec 12 08:09:39 2023 +0100

    fix: si-spectra report generation to work even without preview

    * serialize data for spectra si report on backend

    * add spectra report thumbnail image preview

    * update spectra worker method

    * update attachment api

    ---------

    Co-authored-by: Mehreen <mehreen.mansur>

    Refs:  #1654, #1642

commit 016eab42b1ce350322285e1d8b3879678eb64d35
Author: TasnimMehzabin <TasnimMehzabin@users.noreply.github.com>
Date:   Tue Dec 12 07:58:20 2023 +0100

    feat: add the option to change the inbox sizing

    * feat: add the option to change the inbox sizing
    make the default inbox sizing smaller to col-md-4

    * feat: hide the datetime when inbox size is set to 'Small'
    change small inbox size to col-md-2
    change css for sort button in inbox modal
    modify the info message in the inbox for the sort button

    ---------

    Co-authored-by: Tasnim Mehzabin <tasnim.mehzabin@live.com>
    Co-authored-by: mekkyz <mos.mekky@gmail.com>

    Refs:  #1645

commit b8cde5288c6829bce1f3accccf6d0f6dd8b8b1b1
Author: TasnimMehzabin <TasnimMehzabin@users.noreply.github.com>
Date:   Thu Dec 7 08:46:27 2023 +0100

    test: fix test with deviceBox sorting in inbox

    Co-authored-by: Tasnim Mehzabin <tasnim.mehzabin@live.com>

    Refs: #1657 , #1446

commit fed53fa6568642af069377ebe4ce4b78d70c37b9
Author: TasnimMehzabin <TasnimMehzabin@users.noreply.github.com>
Date:   Tue Dec 5 15:55:56 2023 +0100

    feat: sorting option for datasets and attachments in the inbox by creation-time or name

    * feat: modify the sorting in the inbox based on user selection (name/creation time)
    add test codes
    prevent the deviceBox from being closed when ordering is changed

    deviceBox not to change with the sorting options. They will always be fixed and sorted by the name
    unsorted files are sorted with the selected sorting
    attachments within the datasets are sorted with the selected sorting
    the sorting icon is modified
    the default inbox sizing is made smaller to col-md-4
    tooltip texts are directed downward

    ---------

    Co-authored-by: Tasnim Mehzabin <tasnim.mehzabin@live.com>

    Refs: #1446

commit 3752367b14fadb8f090b62e0c63a97bb3990c53e
Author: Lan Le <baolan2005@gmail.com>
Date:   Tue Dec 5 15:28:23 2023 +0100

    fix(spectra): order of J value

    Co-authored-by: Lan Le <lan.le@kit.edu>

    Ref: #1649, https://github.com/ComPlat/react-spectra-editor/pull/179

commit a87201224d7a2cc88ab9f75342c308ad3295dd8c
Author: Lan Le <baolan2005@gmail.com>
Date:   Tue Dec 5 15:26:15 2023 +0100

    fix(spectra): correctly trigger action spinner when saving peaks to avoid race condition

    Co-authored-by: Lan Le <lan.le@kit.edu>

    Refs: #1651

commit d503a4c5fa135b808bb80c77ef82d310cb40d2e8
Author: TasnimMehzabin <TasnimMehzabin@users.noreply.github.com>
Date:   Wed Nov 29 14:34:32 2023 +0100

    fix: reaction sort column value not being persistent for updated_at column

    Co-authored-by: Tasnim Mehzabin <tasnim.mehzabin@live.com>

    Refs: #1643

commit 97fcdd69aea585f94ac6ff62103968f8c519f181
Author: Mehreen Mansur <mehreen.mansur@gmail.com>
Date:   Wed Nov 29 12:47:59 2023 +0100

    feat: show research plan links in reaction (#1575)

    * add research plans linked to reaction

    * update research plan api

    ---------

    Co-authored-by: Mehreen <mehreen.mansur>

commit baadf31dc2aea0407de05cb188d7e2a15ccd306d
Author: Lan Le <baolan2005@gmail.com>
Date:   Wed Nov 29 11:10:24 2023 +0100

    fix: update chemspectra client to prevent crash on CV layout

    Co-authored-by: Lan Le <lan.le@kit.edu>

    Refs: #1637, https://github.com/ComPlat/react-spectra-editor/pull/177

commit 93f8dce78cd647cec3adb653fb7093cadecc1e74
Author: Fabian Mauz <fmauz@ipb-halle.de>
Date:   Wed Nov 29 11:07:12 2023 +0100

    fix: collection management right click on the add button to not drag things around

    * fix: made root collection undraggable in MyCollections

    * style: changed css style of root collections

    * fix: made root collection in MySharedCollections undraggable

    * fix: made root collection in Shared-and SyncronizedWithMe  undraggable

    * fix: made root collection in CollectionTabs  undraggable

    * style: add some space left to the tree

    * style: add active marking also to root collection

    * fix: suppress drag with root buttons at MyCollections

    * fix: suppress drag with root buttons at MySharedCollections

    refs: #1639, #670

commit 5e3d9814e0761b6617307f961c9f5244033fb4f4
Author: Adam Basha <55552142+adambasha0@users.noreply.github.com>
Date:   Fri Nov 24 10:40:14 2023 +0100

    feat: add volume field in inventory tab (#1613)

    * add volume field in inventory tab

    * fix: apply conditional check for p-statements in chemicalTab

    * fix: verify fetched pictograms from merck

commit cf7e0b077ab652a3f02ea7c7969b6c6b629baed1
Author: StarmanMartin <m.starman@live.com>
Date:   Tue Nov 21 22:32:04 2023 +0100

    feat: Changed Mail collector rules

    * Changed Mail collector rules:
    Attachment e-mails...
     - can be sent to multiple chemotion instances
     - can be sent to chemotion user in 'cc' or 'to'. The e-mail addresses in to and cc are treated equally
     - can be sent to different e-mails. All emails in "cc" or "to" belonging to a registered user will trigger the creation of an attachment. All non-registered e-mails are ignored.

    Additionally, if an e-mail throws an error the collector keeps running. -> mailcollector line 25

    * style: rubocop -A

    Refs: #1566

commit fa19ed25769df52c273037f4eb291c41a4322076
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Tue Nov 21 21:53:06 2023 +0100

    chore: upd node engine for dev container (#1635)

    * chore: upd node engine for dev container

    * feat: enable sentry monitoring for delayed_job

    * chore: upd dockerignore

    * ci: update runner image

    * ci: move faker to global group of Gems to allow user seedings in stage env

commit 9876a63639436999eb9975e5a10541acb9a72b78
Author: Adam Basha <55552142+adambasha0@users.noreply.github.com>
Date:   Mon Nov 20 17:05:02 2023 +0100

    fix: allow import of molecule_name on sample import for xslx format

    * fix: allow import of molecule_name on sample import for xslx format

    * add spec test for importing molecule names on sample import

    Refs: #1598

commit b7f13f4179ad0cf5e31ada00780faa59e59f427c
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Nov 20 16:32:30 2023 +0100

    chore: Bump rmagick from 5.0.0 to 5.3.0

    Bumps [rmagick](https://github.com/rmagick/rmagick) from 5.0.0 to 5.3.0.
    - [Changelog](https://github.com/rmagick/rmagick/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/rmagick/rmagick/commits)

    ---
    updated-dependencies:
    - dependency-name: rmagick
      dependency-type: direct:production
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

    Refs: #1609

commit e3b90c636b0b1cd419f31b59ea591abafb9c9c50
Author: Lan Le <baolan2005@gmail.com>
Date:   Mon Nov 20 16:30:21 2023 +0100

    fix(spectra): Add/remove multiplicity peak buttons(#1630)

    update react-spectra-editor to v1.0.0-rc20

    https://github.com/ComPlat/react-spectra-editor/pull/175

    Co-authored-by: Lan Le <lan.le@kit.edu>

    Refs: 1630

commit 8b8690d8646a9707ee8e40026b213cebbbbfa1f7
Author: Lan Le <baolan2005@gmail.com>
Date:   Mon Nov 20 16:17:20 2023 +0100

    fix(spectra): remove blank line when saving peak

    Co-authored-by: Lan Le <lan.le@kit.edu>

    Refs: #1629

commit e559183511e644df48ec363da9186dcc36f6eb69
Author: Pei Chi Huang <pei-chi.huang@kit.edu>
Date:   Mon Nov 20 15:56:32 2023 +0100

    feat: upgrade-converter-to-v1.1.1

    https://github.com/ComPlat/chemotion-converter-app/releases/tag/v1.1.1

    Refs: #1634

commit 1e43e364e7c4a4d79ac6b3ce0231ccb1890ca13f
Author: TasnimMehzabin <TasnimMehzabin@users.noreply.github.com>
Date:   Fri Nov 17 12:33:07 2023 +0100

    fix: the attachment to be removed from the inbox when assigned to a sample (#1631)

    Co-authored-by: Tasnim Mehzabin <tasnim.mehzabin@live.com>

commit a31a0ffdf84c81e6674b942f4272410431876073
Author: Adam Basha <55552142+adambasha0@users.noreply.github.com>
Date:   Thu Nov 16 08:54:43 2023 +0100

    feat: include chemicals with import and export of collections (#1604)

commit d6c6c9609544343e3d326c086d9c4078567a3778
Author: Pei Chi Huang <pei-chi.huang@kit.edu>
Date:   Thu Nov 16 06:41:31 2023 +0100

    feat: drag samples and elements to segment (#1623)

commit c1e26a2fb8970fbf3ac54c1e40170e98f89effe2
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Thu Nov 16 06:40:34 2023 +0100

    feat: display mail collector address as info in the Inbox (#1529)

    send mail collector address to client if mail collector is configured

    (the last registered alias over the ui api)

    add info button for collecting file per email in inbox modal

    click to copy collector address  to clipboard

    ---------

    Co-authored-by: nh9378 <basha.adam@kit.edu>

commit 09ec1599c0a17ec153b0fdc3941178f85c79a7ee
Author: Lan Le <baolan2005@gmail.com>
Date:   Tue Nov 14 12:29:32 2023 +0100

    feat(spectra): update chemspectra backend to read some jcamp v6 (#1603)

    Co-authored-by: Lan Le <lan.le@kit.edu>

commit 8203debbcfa84f7efb7d06021da63421b03e737a
Author: f-idiris <112618970+f-idiris@users.noreply.github.com>
Date:   Tue Nov 14 12:28:20 2023 +0100

    feat: report peaks from XRD (#1614)

commit da0074b4e3a585baf37698f8e6015cf624de7091
Author: Pei Chi Huang <pei-chi.huang@kit.edu>
Date:   Tue Nov 7 12:30:53 2023 +0100

    feat: better grouping of decoupled samples in list (#1612)

commit ab9f67a5c4ea265edcf5ae7396a160676d067fdc
Author: Lan Le <baolan2005@gmail.com>
Date:   Mon Nov 6 17:36:08 2023 +0100

    fix: polymer bead not visible in reaction svg

    update react-svg-file-zoom-pan to version 1.1.2 so that the polymer bead representation is visible on the reaction preview and detail images.

    Co-authored-by: Lan Le <lan.le@kit.edu>

    refs: #1607

commit be8e927e95f7f7383638e688ed3fa4e742a19986
Author: TasnimMehzabin <TasnimMehzabin@users.noreply.github.com>
Date:   Thu Nov 2 10:15:17 2023 +0100

    feat: add the option to sort reaction list by updated time (#1461)

    * feat: add the option to toggle reaction sort direction

    * fix: update the filter message in the elements table list

    ---------

    Co-authored-by: Tasnim Mehzabin <tasnim.mehzabin@live.com>

commit c61c86a162270ff0c3a2ac5d4806d23ed40bed18
Author: TasnimMehzabin <TasnimMehzabin@users.noreply.github.com>
Date:   Fri Oct 27 10:51:03 2023 +0200

    feat(UI): file size is listed in the analyses tab

    Refs:  #1601
    Co-authored-by: Tasnim Mehzabin <tasnim.mehzabin@live.com>

commit 6f1afba3a0861363e18962df96128d478647989a
Author: TasnimMehzabin <TasnimMehzabin@users.noreply.github.com>
Date:   Thu Oct 26 13:34:19 2023 +0200

    feat(UI): remove redundant inbox section from the collection listing on the left panel

    - leave the left panel for collection browsing
    - Inbox is now only, but clearly, called from the top menu bar

    Refs: #1593

    Co-authored-by: Tasnim Mehzabin <tasnim.mehzabin@live.com>

commit 84c02bced038ef307abb67393a86a3fe71f8bb35
Author: Pei Chi Huang <pei-chi.huang@kit.edu>
Date:   Wed Oct 25 09:48:20 2023 +0200

    feat: converter trigger on attachment inbox items

    Refs: #1583

commit 75fde46a36618f7c887408ff11628bf865a5150f
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Tue Oct 24 22:20:11 2023 +0200

    chore: update VERSION 1.8.0

    chore: update ci image

    chore: minor node upd

    chore: upd changelog

    chore: .gitignore do not track doc/

    Refs: #1576

commit 7bd6a5d811aa6cce2d702418fa502dc3e90f9509
Author: Pei Chi Huang <pei-chi.huang@kit.edu>
Date:   Tue Oct 24 11:52:45 2023 +0200

    fix(UI): reaction list display break when reaction status not standard

    Rendering of Overlay component break UI when a reaction status goes to the switch default case.

    For example on shared reaction with limited permission (reaction.status = "***")

    Refs: #1592

commit 2659436039ac49e87720a09833efdeb330c60c9b
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Oct 24 10:53:22 2023 +0200

    chore: Bump @babel/traverse from 7.16.10 to 7.23.2 (#1580)

    Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.16.10 to 7.23.2.
    - [Release notes](https://github.com/babel/babel/releases)
    - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

    ---
    updated-dependencies:
    - dependency-name: "@babel/traverse"
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 48aef3b04ae3aca429755d4da6f9550237f12e00
Author: Pei Chi Huang <pei-chi.huang@kit.edu>
Date:   Tue Oct 24 10:46:19 2023 +0200

    feat: expand calendar function to generic element

    Refs: #1585

commit 3ef1129914dfb73b32d54b1a52cbd7b65009d7e7
Author: Adam Basha <55552142+adambasha0@users.noreply.github.com>
Date:   Tue Oct 24 06:58:59 2023 +0200

    fix: reaction calculation when no reference material present

    fix break introduced with 40bc206fb0

    Ref: #1589

commit 5f6d6ad50a698903825fa398f842286020dd78eb
Author: Pei Chi Huang <pei-chi.huang@kit.edu>
Date:   Mon Oct 16 09:27:08 2023 +0200

    chore: update labimotion - converter ui  (#1578)

    fix: converter app call not triggered

commit 6b1438478040eb356be4dcc80152d3c7b3f965a4
Author: Lan Le <baolan2005@gmail.com>
Date:   Tue Oct 10 10:11:06 2023 +0200

    fix: hide spectra button when only uploading an image (#1568)

    Co-authored-by: Lan Le <lan.le@kit.edu>

commit 10ef1f11cd39750ccdb72df4152dfedf6af56c44
Author: Adam Basha <55552142+adambasha0@users.noreply.github.com>
Date:   Tue Oct 10 10:10:05 2023 +0200

    fix: assign only boolean values for decoupled column when importing samples (#1571)

commit 894306a126f6f1546825235eee256dc51ffd8316
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Tue Oct 10 08:49:55 2023 +0200

    fix: Admin seed: ensure exisiting Admins have a profile (#1572)

    - fix: navigation/call to user-profile depending page/action

    - fix: README links to docs (trailing '/' routing)

commit e2ee14b1d824a03a203920947965da8498980e4b
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Oct 10 08:48:02 2023 +0200

    chore: Bump @adobe/css-tools from 4.2.0 to 4.3.1 (#1511)

    Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.1.
    - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md)
    - [Commits](https://github.com/adobe/css-tools/commits)

    ---
    updated-dependencies:
    - dependency-name: "@adobe/css-tools"
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 3de16fa33e1bdb7eaba46c3f793fd346aca7ac83
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Mon Oct 9 16:08:16 2023 +0200

    fix:  rollback labi version up (#1570)

commit 0781e5cda2d2b25a430193018ea5cf46d22799e3
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Mon Oct 9 13:59:49 2023 +0200

    prep v1.8.0-rc2

commit c4200dffad7d30f20aa0b7cb1654ba21cc11c63b
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Mon Oct 9 13:53:52 2023 +0200

    chore: minor dep updates (#1569)

    * chore: minor update sentry

    * fix: typo env var for sentry monitoring

    * chore: update service dep

    * fix: downgrade labimotion to prevent converter process early exit

    * chore: yarn audit fix

commit d55520d512d40502b455b54d39c912ef54c0facb
Author: Lan Le <baolan2005@gmail.com>
Date:   Mon Oct 9 13:48:18 2023 +0200

    feat: update chemspectra to change value of referent solvent (#1557)

    Co-authored-by: Lan Le <lan.le@kit.edu>

commit bebdec0eea8170f21a36e97f64756b0aaf84a279
Author: Mostafa Mekky <59936007+mekkyz@users.noreply.github.com>
Date:   Mon Oct 9 13:05:19 2023 +0200

    fix: sample properties tab (#1503)

    * Fix: style issue for boxes in sample

    * Enhancement: hide labels when there is no solvent

    * Decoupled checkbox padding

    * test: add test for SampleSolvent rendering

    * test: add test for SolventDetails rendering

    ---------

    Co-authored-by: FabianMauz <fmauz@ipb-halle.de>

commit be0bcd83da967882e3e912f2d9ed58ccf302caf6
Author: Lan Le <baolan2005@gmail.com>
Date:   Mon Oct 9 12:45:08 2023 +0200

    feat: show nmrium button for reaction and research plan (#1471)

    Co-authored-by: Lan Le <lan.le@kit.edu>

commit ee881fefd4ce37da533db58a325687c0320e71fa
Author: Jan C. Brammer <jan.c.brammer@gmail.com>
Date:   Mon Oct 9 12:35:31 2023 +0200

    feat: update reaction variations (#1567)

    * Rename variable for consistency

    * Use React Bootstrap buttons

    * Identify variations with sequential ID

    * Add vertical space around table tools

    * Remove uncessary guard

commit 3c0b1e4de6af5a3870ce6c4f6eac2947749cbf40
Author: Fabian Mauz <fmauz@ipb-halle.de>
Date:   Fri Oct 6 10:53:09 2023 +0200

    fix: no attachments after research plan save

    * fix: add Attachment Fetcher as uploader for attachments

    * fix: upload attachments via AttachmentFetcher

    * fix: add needed parameter for next promise step

    * fix: upload attachments in genericElsFetcher only if no researchplan

    * fix: create multiple attachments on researchplan create

    * test: add tests for getting attachments of researchplan

    * fix: removed deprecated thumbnail job

    * fix: WIP map identifier to attachment

    * fix: removed index from loop

    * fix: add identifier to params

    * refactor: use loop with index instead of own index variable

    * todo: remove uploading of attachments via GenericElsFetcher and do the same for update usecase

    Refs: #1564
    ---------
    Co-authored-by: nh9378 <basha.adam@kit.edu>

commit c1b45ae4105d2d19e74b88a5761cb41eb873e128
Author: Adam Basha <55552142+adambasha0@users.noreply.github.com>
Date:   Thu Oct 5 19:07:28 2023 +0200

    feat: Import export sample as chemical

    * implementation for import chemicals to collection, added import_chemicals class and spec tests and refactored import_samples class to add import_type option to import samples

    * refactor construct_p_statements and construct_h_statements methods in chemical_service to solve duplication issue and refactored chemicals_service_spec tests accordingly

    * handle failing of import chemicals (sample will not be created, user will be notified which samples could not be imported, refactor import_chemicals and spec tests

    * allow import cas field on sample import for xlsx format

    * import chemicals: allow skipping import of chemical field if column header is null

    * refactor report_api code for exporting samples and chemicals

    * refactor code of export chemicals in report_helpers module into own class and improve export functionality of chemicals

    * write unit tests for ExportChemicals class

    * disable sdf format option for chemicals export and adjust exportModal height

    * refactor ExportImportButton component

    * refactor report_helpers module and import_samples_spec  to fix failing spec in report_api_spec and import_samples_spec

    * allow import of decoupled samples

    * allow import & export of decoupled samples

    * allow SDS search for chemical when molecule does not exist (for decoupled samples)

    * allow import of merck safety sheets on import chemicals

    * allow import of float amount values for import chemicals

    * allow sample import with case insensitive values of decoupled column

    Refs: #1524

commit 77a091b7689af3731ae356791794cfc081eac3f4
Author: Lan Le <baolan2005@gmail.com>
Date:   Thu Oct 5 19:02:52 2023 +0200

    fix: add filter for NMR kind

    check if NMR CHMO entry is an ancestor
    Co-authored-by: Lan Le <lan.le@kit.edu>
    Ref: #1563

commit 10d35642ccb7e11b448fd6f06164171bf75b2d7f
Author: TasnimMehzabin <TasnimMehzabin@users.noreply.github.com>
Date:   Thu Oct 5 08:40:55 2023 +0200

    feat: add a checkbox for dry solvents in the solvents section in the reactions table

    * add a checkbox for dry solvents in the solvents section in the reactions table
    add option to mark sample as dry solvent

    * refactor the code to fix rubocop warnings

    * allow import of dry_solvent attribute in import samples for xlsx and sdf formats

    * adjust dry-solvent element width in sampleForm component

    Refs:  #1432
    ---------

    Co-authored-by: nh9378 <basha.adam@kit.edu>

commit 1795b4b0729e0aea14909438099db628baf20c9c
Author: Adam Basha <55552142+adambasha0@users.noreply.github.com>
Date:   Thu Oct 5 08:36:14 2023 +0200

    fix: load cas for molecules

    * fix loading cas when using pubchem service

    Refs: #1555

commit 1211fd6b0694e4485af951742b5aba037a296916
Author: TasnimMehzabin <TasnimMehzabin@users.noreply.github.com>
Date:   Thu Oct 5 07:55:25 2023 +0200

    fix: current_user.matrix getting null value

    Refs: #1554

commit c5c7b2faf4c7161d6e52dc4bd75ea976e1f54e4f
Author: Adam Basha <55552142+adambasha0@users.noreply.github.com>
Date:   Thu Oct 5 07:54:43 2023 +0200

    fix: show example reaction label in settings page

    Refs: #1556

commit 06aa179b1fea53dc393cfc93877c69369e369509
Author: Jan C. Brammer <jan.c.brammer@gmail.com>
Date:   Thu Oct 5 07:52:47 2023 +0200

    feat: update reaction variations

    * Use `name` as default material identifier

    * Allow zero ('0') values

    * Extend tooltip

    * Make inclusion of `variations` in report optional

    * Guard against missing material types

    * Allow any precision for numerical input

    Refs #1561

commit e73d76ed36e5ba214d9033c709b0d25fa210c7f6
Author: TasnimMehzabin <TasnimMehzabin@users.noreply.github.com>
Date:   Wed Sep 27 15:56:52 2023 +0200

    fix: comment fetch issue on new entities

    Refs: #1547

commit 9992a85878d4fb272b4fca9639b8d35f3c93f3f6
Author: Lan Le <baolan2005@gmail.com>
Date:   Wed Sep 27 15:54:56 2023 +0200

    chore: update chemspectra backend version to display label cv layout

    Co-authored-by: Lan Le <lan.le@kit.edu>
    Refs: #1546

commit ba6c1d9af0334da5a86c23d14e64714e0fe3a7f7
Author: Lan Le <baolan2005@gmail.com>
Date:   Wed Sep 27 09:36:41 2023 +0200

    feat: display combined image as preview if it exists

    fixed: fix UI issue on CV layout

    Co-authored-by: Lan Le <lan.le@kit.edu>

    Refs: #1526

commit 1a9fc9e730f24ffed42ef928b3938693a47e47ff
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Fri Sep 22 13:23:25 2023 +0200

    fix: wrong conflict resolution (#1542)

commit fc4bf31e40400f43c88604a36396b886f6ef073e
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Fri Sep 22 09:00:35 2023 +0200

    test: update runner image (#1541)

commit 154e18cea48ddd3b4c1c7b45623d16d501ca59a9
Author: Mostafa Mekky <59936007+mekkyz@users.noreply.github.com>
Date:   Thu Sep 21 15:06:56 2023 +0200

    test: "yarn test" errors & warnings

    * fix: removed useless prop "bsSize"

    * fix: added polyfills for unsupported browsers

    * fix: used instance of attachement

    * fix: disabled lifecycle update for testing

    * fix: added attachments as prop

    * Refactor: stub ChemicalFetcher.create & eslint fix

    * Fix: yarn test errors for ChemicalTab

    Refs: #1523

commit 4bd661989e4e1d98f8b0fee733794f0e20197299
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Wed Sep 20 07:19:47 2023 +0200

    chore: prep v1.8.0-rc1

commit 98665123f0ab527ee71537eef2e0b3c43c9d1d69
Author: Pei Chi Huang <pei-chi.huang@kit.edu>
Date:   Wed Sep 20 07:12:07 2023 +0200

    feat: LabiIMotion Integration

    * Generic Element
    * Generic Segment
    * Generic Dataset

    Refs: #1504

    ---------

    Co-authored-by: Claire Lin <chia-lin.lin@kit.edu>

commit 728e95ff4388fd9cb34e2bd6b582e1fd341e952b
Author: PiTrem <pierre.tremouilhac@kit.edu>
Date:   Wed Sep 20 07:04:50 2023 +0200

    fix: assets precompilation css issue

    ```
    SassC::SyntaxError: Error: "var(--ag-internal-calculated-line-height)" is not a number for `min'
            on line 2381:11 of stdin, in function `min`
            from line 2381:11 of stdin
    >>   height: min(var(--ag-internal-calculated-line-height), var(--ag-internal-p
    ```
    Refs:  #1538

commit 1b540e188ca8da89f71a4bcecd9b70cb0e65099f
Author: Jan C. Brammer <jan.c.brammer@gmail.com>
Date:   Wed Sep 20 07:01:01 2023 +0200

    feat: Reaction Variations

    * Add variations tab to reaction detail modal

    * Update `ag-grid` JS dependencies

    * Correctly deconstruct `material.amount`

    * Try using material labels as column headers

    * Extend example data structure for clarity

    * Show cell entries with three decimal places

    * Individualize reference material per row

    Make reference m…
@JanCBrammer JanCBrammer mentioned this pull request Apr 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiTrem PiTrem PiTrem approved these changes

@soerenPeters soerenPeters soerenPeters approved these changes

Assignees

@soerenPeters soerenPeters

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JanCBrammer @PiTrem @soerenPeters