Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cargo-codspeed): rethrow exit code #86

Conversation

not-matthias
Copy link
Contributor

Signals can be rewritten to error codes (see: https://stackoverflow.com/a/24104579)

Copy link

codspeed-hq bot commented Mar 7, 2025

CodSpeed Instrumentation Performance Report

Merging #86 will degrade performances by 18.88%

Comparing cod-615-distinguish-instrumented-command-and-tool-error-in-codspeed (d722816) with main (e40765d)

Summary

⚡ 6 improvements
❌ 6 regressions
✅ 151 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
bench_array1[42] 1.1 µs 1.1 µs +5.51%
bench_array1[4] 125.3 ns 154.4 ns -18.88%
bench_array2[42] 1.1 µs 1.1 µs +5.51%
bench_array2[4] 125.3 ns 154.4 ns -18.88%
init_array[42] 1.1 µs 1.1 µs +5.51%
init_array[4] 154.4 ns 183.6 ns -15.89%
mut_borrow 866.7 ns 895.8 ns -3.26%
recursive[0] 211.1 ns 240.3 ns -12.14%
recursive[5] 291.1 ns 320.3 ns -9.11%
recursive_memoized[BTreeMap<u64, u64>, 0] 400.8 ns 371.7 ns +7.85%
instant 363.6 ns 334.4 ns +8.72%
system_time 363.6 ns 334.4 ns +8.72%

Copy link

codspeed-hq bot commented Mar 7, 2025

CodSpeed Walltime Performance Report

Merging #86 will degrade performances by 52.24%

Comparing cod-615-distinguish-instrumented-command-and-tool-error-in-codspeed (d722816) with main (e40765d)

Summary

⚡ 2 improvements
❌ 21 regressions
✅ 86 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
init_array[1000] 4.1 µs 2 µs ×2
generate_combinations[5] 3.1 µs 3.3 µs -6.82%
generate_combinations[6] 1.3 µs 1.4 µs -5.22%
generate_combinations[9] 4.3 µs 4.5 µs -4.55%
generate_parentheses[3] 2.3 µs 2.4 µs -4.98%
generate_parentheses[4] 6.9 µs 7.4 µs -6.68%
generate_parentheses[5] 22.1 µs 23.3 µs -5.3%
hamiltonian_cycle[4] 4.4 µs 4.6 µs -4.41%
hamiltonian_cycle[5] 5.2 µs 5.5 µs -4.59%
hamiltonian_cycle[6] 5.7 µs 6 µs -4.02%
hamiltonian_cycle[7] 6.5 µs 6.9 µs -5.57%
n_queens_solver[4] 1.6 µs 1.8 µs -6.85%
permutations[3] 2.8 µs 2.9 µs -3.69%
permutations[6] 66.2 µs 74.3 µs -10.9%
permutations[7] 777.9 µs 837.9 µs -7.16%
rat_in_maze[5] 4.7 µs 4.9 µs -4.15%
rat_in_maze[6] 2.8 µs 5.9 µs -52.24%
rat_in_maze[7] 3.2 µs 3.3 µs -3.23%
add_two_integers[(0, 0)] 5.6 µs 5.9 µs -5.66%
generate_gray_code[1] 4.2 µs 2.1 µs +98.88%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

olgtm

@not-matthias not-matthias force-pushed the cod-615-distinguish-instrumented-command-and-tool-error-in-codspeed branch from c738f41 to c55c22a Compare March 7, 2025 16:56
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise

The Rock Nice LGTM

@not-matthias not-matthias force-pushed the cod-615-distinguish-instrumented-command-and-tool-error-in-codspeed branch from c55c22a to d722816 Compare March 7, 2025 17:38
@not-matthias not-matthias merged commit d722816 into main Mar 7, 2025
5 of 6 checks passed
@not-matthias not-matthias deleted the cod-615-distinguish-instrumented-command-and-tool-error-in-codspeed branch March 7, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants