Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support consts with divan #84

Merged

Conversation

not-matthias
Copy link
Contributor

Closes #82

Copy link

codspeed-hq bot commented Mar 3, 2025

CodSpeed Instrumentation Performance Report

Merging #84 will degrade performances by 24.48%

Comparing cod-609-please-can-you-support-divanbenchconsts-xxx (e40765d) with main (5517175)

Summary

⚡ 2 improvements
❌ 2 regressions
✅ 148 untouched benchmarks
🆕 11 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 bench_array1[10] N/A 225 ns N/A
🆕 bench_array1[1] N/A 90 ns N/A
🆕 bench_array1[42] N/A 1.1 µs N/A
🆕 bench_array1[4] N/A 125.3 ns N/A
🆕 bench_array2[10] N/A 225 ns N/A
🆕 bench_array2[1] N/A 90 ns N/A
🆕 bench_array2[42] N/A 1.1 µs N/A
🆕 bench_array2[4] N/A 125.3 ns N/A
🆕 init_array[1000] N/A 11.4 µs N/A
🆕 init_array[42] N/A 1.1 µs N/A
🆕 init_array[4] N/A 154.4 ns N/A
fibo_10 90 ns 119.2 ns -24.48%
fibo_500 286.9 ns 257.8 ns +11.31%
mut_borrow 866.7 ns 895.8 ns -3.26%
recursive_memoized[BTreeMap<u64, u64>, 0] 400.8 ns 371.7 ns +7.85%

Copy link

codspeed-hq bot commented Mar 3, 2025

CodSpeed Walltime Performance Report

Merging #84 will degrade performances by 54.88%

Comparing cod-609-please-can-you-support-divanbenchconsts-xxx (e40765d) with main (5517175)

Summary

⚡ 10 improvements
❌ 4 regressions
✅ 84 untouched benchmarks
🆕 11 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 bench_array1[10] N/A 4.9 µs N/A
🆕 bench_array1[1] N/A 3.6 µs N/A
🆕 bench_array1[42] N/A 6.5 µs N/A
🆕 bench_array1[4] N/A 3.9 µs N/A
🆕 bench_array2[10] N/A 4.9 µs N/A
🆕 bench_array2[1] N/A 3.6 µs N/A
🆕 bench_array2[42] N/A 6.5 µs N/A
🆕 bench_array2[4] N/A 3.9 µs N/A
🆕 init_array[1000] N/A 2.1 µs N/A
🆕 init_array[42] N/A 6.5 µs N/A
🆕 init_array[4] N/A 3.9 µs N/A
fibo_10 4.5 µs 3.6 µs +24.67%
recursive_memoized[BTreeMap<u64, u64>, 20] 3.4 µs 1.7 µs ×2
generate_combinations[6] 2.6 µs 1.3 µs ×2
generate_combinations[8] 3.1 µs 3 µs +3.6%
generate_parentheses[5] 20.8 µs 21.9 µs -4.83%
graph_coloring[3] 1.1 µs 2.3 µs -54.88%
hamiltonian_cycle[4] 4.6 µs 4.4 µs +4.91%
n_queens_solver[5] 9.3 µs 8.8 µs +5.58%
permutations[5] 14.1 µs 15.2 µs -7.35%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@joseph-isaacs
Copy link

This is great! thanks

Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, appart from the clippy lint that needs to be ignored for the CI to pass !

Same remark about commit signature

@not-matthias not-matthias force-pushed the cod-609-please-can-you-support-divanbenchconsts-xxx branch from b6dbb75 to f897280 Compare March 4, 2025 10:30
Signed-off-by: not-matthias <matthias@codspeed.io>
@not-matthias not-matthias force-pushed the cod-609-please-can-you-support-divanbenchconsts-xxx branch from f897280 to e40765d Compare March 4, 2025 13:10
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@not-matthias not-matthias merged commit e40765d into main Mar 4, 2025
5 of 6 checks passed
@not-matthias not-matthias deleted the cod-609-please-can-you-support-divanbenchconsts-xxx branch March 4, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please can you support divan::bench(consts = xxx)
3 participants