Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add an internal divan fork #69

Merged
merged 5 commits into from
Feb 6, 2025
Merged

chore: add an internal divan fork #69

merged 5 commits into from
Feb 6, 2025

Conversation

art049
Copy link
Member

@art049 art049 commented Feb 5, 2025

  • chore: initial fork of divan
  • chore(divan_fork): integrate the fork within the workspace
  • fix(divan_fork): fix existing test suites
  • feat(divan_fork): add the codspeed walltime collection point

@art049 art049 force-pushed the fork-divan-internally branch from 19d4905 to 8beea63 Compare February 5, 2025 17:03
Copy link

codspeed-hq bot commented Feb 5, 2025

CodSpeed Walltime Performance Report

Merging #69 will create unknown performance changes

Comparing fork-divan-internally (95b1ea6) with main (fedf402)

Summary

🆕 2 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 fibo_100 N/A 3.6 µs N/A
🆕 fibo_500 N/A 7.2 µs N/A

Copy link

codspeed-hq bot commented Feb 5, 2025

CodSpeed Instrumentation Performance Report

Merging #69 will not alter performance

Comparing fork-divan-internally (95b1ea6) with main (fedf402)

Summary

✅ 54 untouched benchmarks

@art049 art049 requested a review from adriencaccia February 5, 2025 17:14

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@art049 art049 force-pushed the fork-divan-internally branch from 136db80 to 2df535e Compare February 6, 2025 09:22
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

olgtm, let me know if you need my input once it's a module and not a crate 😎

@art049 art049 force-pushed the fork-divan-internally branch from 2df535e to 95b1ea6 Compare February 6, 2025 09:50
@art049 art049 merged commit 95b1ea6 into main Feb 6, 2025
6 checks passed
@art049 art049 deleted the fork-divan-internally branch February 6, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants