-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codspeed<>divan compat layer #65
Conversation
CodSpeed Instrumentation Performance ReportMerging #65 will not alter performanceComparing Summary
|
215028a
to
e2f2e7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty cool overall and seem much more simple than for our other integration! let's go 💪
7802d9a
to
c2cab59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to run those new benches in the ci workflow before merging
682d7af
to
8104c13
Compare
CodSpeed Walltime Performance ReportMerging #65 will not alter performanceComparing Summary
Benchmarks breakdown
|
8104c13
to
d9e5e62
Compare
02ab31a
to
055d0f9
Compare
055d0f9
to
3d7a2a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
As discused, can you undo the reformating of the doctest in the divan fork's doctests?
3d7a2a3
to
56ae65f
Compare
56ae65f
to
d525802
Compare
Currently implemented
#[divan::bench]
divan::bench
macro.with_inputs()
TODO before first release