Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: simplify rust benchmarks definition #44

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

adriencaccia
Copy link
Member

Simplify how rust benchmarks are defined by removing the need to install both criterion and codspeed-criterion-compat, or both bencher and codspeed-bencher-compat.

@adriencaccia adriencaccia requested a review from art049 April 29, 2024 19:41
Copy link

codspeed-hq bot commented Apr 29, 2024

CodSpeed Performance Report

Merging #44 will degrade performances by 3.08%

Comparing docs/rust-compat (280d7a0) with main (2c67f80)

Summary

❌ 1 regressions
✅ 53 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main docs/rust-compat Change
fibo_recursive 916.7 ns 945.8 ns -3.08%

Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed together, we also need to keep the old definition in the docs not to entirely replace the usage.

@adriencaccia adriencaccia merged commit 280d7a0 into main Jan 7, 2025
4 checks passed
@adriencaccia adriencaccia deleted the docs/rust-compat branch January 7, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants