Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visionos as a new platform #745

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Conversation

gabrieldonadel
Copy link
Contributor

@gabrieldonadel gabrieldonadel commented Jun 26, 2023

This PR introduces visionOS as a supported platform in Core. This primarily involves making the DSL helpers accessible for this platform. This lays the groundwork for supporting visionOS as a new platform in CocoaPods.

Related to CocoaPods/CocoaPods#11961, CocoaPods/Xcodeproj#913 and CocoaPods/CocoaPods#11965

@gabrieldonadel gabrieldonadel changed the title Add visionOS as a new platform Add visionos as a new platform Jun 26, 2023
@dnkoutso
Copy link
Contributor

We might need to bump the min version of Xcodeproj here required going forward as older versions wont work with visionOS.

@gabrieldonadel
Copy link
Contributor Author

We might need to bump the min version of Xcodeproj here required going forward as older versions wont work with visionOS.

Tests should be fixed now
image

Where should I bump the min version of Xcodeproj? Is that set inside CocoaPods/Core or CocoaPods/Xcodeproj?

@dnkoutso
Copy link
Contributor

Once I make a release of Xcodeproj we should update this https://github.com/CocoaPods/CocoaPods/blob/master/cocoapods.gemspec#L40

@dnkoutso dnkoutso added this to the 1.13.0 milestone Jun 27, 2023
@dnkoutso dnkoutso merged commit 034be3e into CocoaPods:master Jun 27, 2023
3 of 4 checks passed
@gabrieldonadel gabrieldonadel deleted the visionOS branch June 27, 2023 17:35
@NachoSoto
Copy link

I don't think this is fully ready: CocoaPods/CocoaPods#11965 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants