Support visionos in pod lib lint --platforms= and use xros for Fourflusher
#12159
Conversation
MagnificentMiles
changed the title
pod lib lint --platforms= and use xros for Fourflushvisionos in pod lib lint --platforms= and use xros for Fourflush
MagnificentMiles
changed the title
visionos in pod lib lint --platforms= and use xros for Fourflushvisionos in pod lib lint --platforms= and use xros for Fourflush
MagnificentMiles
changed the title
visionos in pod lib lint --platforms= and use xros for Fourflushvisionos in pod lib lint --platforms= and use xros for Fourflusher
| @@ -1108,7 +1108,7 @@ def xcodebuild(action, scheme, configuration, deployment_target:) | |||
| command += Fourflusher::SimControl.new.destination(:oldest, 'tvOS', deployment_target) | |||
| when :visionos | |||
| command += %w(CODE_SIGN_IDENTITY=- -sdk xrsimulator) | |||
| command += Fourflusher::SimControl.new.destination(:oldest, 'visionOS', deployment_target) | |||
| command += Fourflusher::SimControl.new.destination(:oldest, 'xrOS', deployment_target) | |||
There was a problem hiding this comment.
Apple has been changing all xrOS references to visionOS. Does this still work with Xcode 15.1? Should Fourflusher be changed instead?
There was a problem hiding this comment.
Is this fix sufficient? CocoaPods/Core#763
There was a problem hiding this comment.
Apple has been changing all xrOS references to visionOS. Does this still work with Xcode 15.1? Should Fourflusher be changed instead?
I tested this in Xcode 15.1 Beta 3 with xrOS and it worked. But I'm happy to make the change in Fourflusher instead!
It seems like Fourflusher just passes the value directly into xcodebuild so probably shouldn't make the change there? Might be better to document that xrOS is the value that is supported as of 15.1 incase it changes in future versions of Xcode? Or should that logic be contained in Fourflusher? I'm not super familiar with Fourflusher's design 🤷♂️
MagnificentMiles
force-pushed
the
support-visionos-in-pod-lib-lint
branch
from
0fcdf6e
to
82e16dd
Compare
| @@ -25,7 +25,7 @@ def self.options | |||
| ['--use-static-frameworks', 'Lint uses static frameworks during installation'], | |||
| ["--sources=#{Pod::TrunkSource::TRUNK_REPO_URL}", 'The sources from which to pull dependent pods ' \ | |||
| "(defaults to #{Pod::TrunkSource::TRUNK_REPO_URL}). Multiple sources must be comma-delimited"], | |||
| ['--platforms=ios,macos', 'Lint against specific platforms (defaults to all platforms supported by the ' \ | |||
| ['--platforms=ios,macos,visionos', 'Lint against specific platforms (defaults to all platforms supported by the ' \ | |||
There was a problem hiding this comment.
I think this is an example? maybe its missing tvos, watchos, but not for this PR.
|
Looks like this is still failing though:
|
|
Hi, are there any plans to release v10.15 with this fix? //cc @amorde |
|
^ |
|
I don't think this is working yet anyway. |
|
FYI this is still broken on CocoaPods 1.15.0:
|
|
I did release this in 1.15.0 but I had missed that it wasn't quite working properly. I likely won't have time available to dig into this until the weekend but happy to review PRs if anyone would like to take a shot at addressing the remaining issues |
|
Turns out that using |
|
Ah ok great. Thanks for digging in to that 🙏 |
Motivation
Fixes #11965 (comment)
And possibly Firebase and RevenueCat
Description
visionosto--platformsinpod lib lintxroswhen passing intoFourflusherERROR | [visionOS] unknown: Encountered an unknown error (Could not find axsossimulator (valid values: ios, tvos, watchos, xros). Ensure that Xcode -> Window -> Devices has at least onexsossimulator listed or otherwise add one.And this is my first CocoaPods pull request so let me know if there is anything else I can do make this PR easier to merge!