Fixed: Preserve ordering when executing batched paging queries. #7994
+191
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7994 +/- ##
==========================================
+ Coverage 74.39% 74.41% +0.01%
==========================================
Files 2898 2898
Lines 152316 152294 -22
Branches 17782 17779 -3
==========================================
+ Hits 113319 113328 +9
+ Misses 33099 33069 -30
+ Partials 5898 5897 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using paging DataLoader the ordering was dropped from the generated SQL query. EF core drops the ordering in case of GroupBy. We had an issue with the expression rewriter which stripped order from original query and moved it into the select after the groupBy.