Fixed EfQueryableCursorPagingHandler (hasNextPage & hasPreviousPage) #7506
+179
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for your help! |
src/HotChocolate/Data/src/EntityFramework/Pagination/EfQueryableCursorPagingHandler.cs
Outdated
Show resolved
Hide resolved
| fetchCount++; | ||
|
|
||
| if (fetchCount >= requestedCount) |
There was a problem hiding this comment.
the actual issue was this check
There was a problem hiding this comment.
Yes, indeed. If the only change would've been if (fetchCount > requestedCount) without altering the order (incrementing the count first and then adding the entities), it results in reading and adding one entity too many (first 10 -> returns 11).
michaelstaib
approved these changes
Sep 25, 2024
michaelstaib
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
Ensure that the
fetchCountcan be greater thanarguments.Firstandarguments.Lasttherefore settinghasNextPageandhasPreviousPageaccordinglyAdded tests to check for
hasNextPageandhasPreviousPageCloses #7500