Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured correct culture is set on tests to match culture dependent snapshots #7496

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

jarlef
Copy link
Contributor

@jarlef jarlef commented Sep 23, 2024

Some tests compare the results of graphql queries agains a snapshot. If the snapshot contains numbers or dates/time the assertion will not match if the machine running the test is not using the same culture setting. The current tests fails due to my local culture (no-NB) formats numbers using comma instead of dot as decimal precision.

To solve this the current PR adds the UseCultureAttribute from the xunit sample code and annotated the failing tests to use en-US culture.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@michaelstaib michaelstaib merged commit 0e806e3 into ChilliCream:main Sep 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants