Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable EnsureAllNodesCanBeResolved by default #7494

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

tobias-tengler
Copy link
Collaborator

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@github-actions github-actions bot added 📚 documentation This issue is about working on our documentation. 🌶️ hot chocolate labels Sep 23, 2024
@tobias-tengler tobias-tengler force-pushed the validate-each-node-has-a-node-resolver branch from 5a22395 to ea38f12 Compare September 23, 2024 15:42
@tobias-tengler tobias-tengler added the 👓 ready-for-review The PR is ready for review. label Sep 23, 2024
@tobias-tengler tobias-tengler force-pushed the validate-each-node-has-a-node-resolver branch from 98c4ee6 to c531d3d Compare September 23, 2024 15:55
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.88%. Comparing base (6e180ce) to head (04a7807).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7494      +/-   ##
==========================================
+ Coverage   77.87%   77.88%   +0.01%     
==========================================
  Files        2825     2825              
  Lines      141934   141934              
==========================================
+ Hits       110527   110550      +23     
+ Misses      31407    31384      -23     
Flag Coverage Δ
unittests 77.88% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit a3e364c into main Sep 24, 2024
98 checks passed
@michaelstaib michaelstaib deleted the validate-each-node-has-a-node-resolver branch September 24, 2024 07:34
michaelstaib pushed a commit that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation This issue is about working on our documentation. 🌶️ hot chocolate 👓 ready-for-review The PR is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants