Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos-15 / macos-13 #248

Merged
merged 1 commit into from
Feb 26, 2025
Merged

macos-15 / macos-13 #248

merged 1 commit into from
Feb 26, 2025

Conversation

johnnynunez
Copy link
Contributor

This pull request includes updates to the GitHub Actions workflow configuration for testing on MacOS. The changes involve specifying the architecture for different MacOS versions and updating the setup process for CastXML based on the architecture.

Updates to GitHub Actions workflow:

  • .github/workflows/tests.yml: Added architecture specification (x86_64 and arm64) for MacOS versions 13 and 15 respectively.
  • .github/workflows/tests.yml: Updated the setup process for CastXML to download the appropriate version based on the MacOS version and architecture.

@johnnynunez johnnynunez changed the title macos-15 macos-15 / macos-13 Feb 22, 2025
@johnnynunez
Copy link
Contributor Author

johnnynunez commented Feb 22, 2025

@iMichka macos-15 x86 fails because macos-15 and macos-14 are arm runners only. So, binary in castxml is arm64(wrong) for x86
Fixed on: CastXML/CastXMLSuperbuild#67

@johnnynunez
Copy link
Contributor Author

here the job is done! Only when macos-13 castxml 0.6.11 will be uploaded

@iMichka
Copy link
Collaborator

iMichka commented Feb 22, 2025

Makes sense, I did not realise that. Nice catch.

@johnnynunez
Copy link
Contributor Author

@thewtex thank you! @iMichka done :)

@iMichka iMichka merged commit 0e50761 into CastXML:develop Feb 26, 2025
16 checks passed
@iMichka
Copy link
Collaborator

iMichka commented Feb 26, 2025

Merged. I just squashed your commits as a single one. Thanks for this !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants