Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PART 1: castxml 0.6.11 x86_64 #247

Merged
merged 2 commits into from
Feb 22, 2025
Merged

PART 1: castxml 0.6.11 x86_64 #247

merged 2 commits into from
Feb 22, 2025

Conversation

johnnynunez
Copy link
Contributor

This pull request updates the .github/workflows/tests.yml file to include architecture specification and improve the setup process for CastXML on different operating systems. The most important changes include adding the arch field to the job matrix and splitting the CastXML setup steps based on the OS and architecture.

Updates to the job matrix:

  • Added arch: x86_64 to all job entries to specify the architecture for the build matrix. [1] [2] [3] [4]

Improvements to CastXML setup:

  • Split the CastXML setup steps into separate sections for Ubuntu 22.04 and Ubuntu 24.04 based on the OS and architecture.
  • Added specific URLs for downloading CastXML for Ubuntu 22.04 and Ubuntu 24.04.

@johnnynunez
Copy link
Contributor Author

johnnynunez commented Feb 19, 2025

done! You can see the errors of #197 @iMichka

Do you think that, it will be easy to fix?

@iMichka
Copy link
Collaborator

iMichka commented Feb 20, 2025

I will add a few commits on top of yours to try to debug this.
I know the place in the code, it's a tricky bug.

@iMichka iMichka force-pushed the castxml branch 7 times, most recently from 189c529 to 97bbb84 Compare February 20, 2025 22:38
@johnnynunez
Copy link
Contributor Author

awesome @iMichka

@iMichka
Copy link
Collaborator

iMichka commented Feb 20, 2025

Found it. I still need to cleanup my mess and review the pull request. I'll do that tomorrow.

@johnnynunez
Copy link
Contributor Author

johnnynunez commented Feb 20, 2025

Do you plan to upload release on pypi when we finish all steps (macos15, ubuntu runners and maybe windows)?

also we can create automatically a CI for create wheels and upload to pypi when release is tagged on github. What do you think? @iMichka

@johnnynunez johnnynunez mentioned this pull request Feb 21, 2025
johnnynunez and others added 2 commits February 21, 2025 08:02

Verified

This commit was signed with the committer’s verified signature.
iMichka Michka Popoff
Let's do the string replacement upfront to get it out of the way.
Else if remove_defaults_impl returns None, the name might not always be cleaned up
@johnnynunez
Copy link
Contributor Author

@iMichka when will it be merged?

@iMichka iMichka merged commit 446e873 into CastXML:develop Feb 22, 2025
16 checks passed
@iMichka
Copy link
Collaborator

iMichka commented Feb 22, 2025

@iMichka when will it be merged?

Done

Do you plan to upload release on pypi when we finish all steps (macos15, ubuntu runners and maybe windows)?

The wheels are "none-any" wheels, as pygccxml is pure Python. Yes I will upload a new release.
I will do this after the CI update for macOS and ARM64.
You can now open pull requests for these.

also we can create automatically a CI for create wheels and upload to pypi when release is tagged on github. What do you think? @iMichka

Yes I plan to do that, will have to edit the GitHub action and automatise it. But I'll keep that for a later version, let's focus on shipping the current changes quickly.

@johnnynunez
Copy link
Contributor Author

@iMichka when will it be merged?

Done

Do you plan to upload release on pypi when we finish all steps (macos15, ubuntu runners and maybe windows)?

The wheels are "none-any" wheels, as pygccxml is pure Python. Yes I will upload a new release. I will do this after the CI update for macOS and ARM64. You can now open pull requests for these.

also we can create automatically a CI for create wheels and upload to pypi when release is tagged on github. What do you think? @iMichka

Yes I plan to do that, will have to edit the GitHub action and automatise it. But I'll keep that for a later version, let's focus on shipping the current changes quickly.

thank you so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants