forked from pydata/pydata-sphinx-theme
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Track if users has dismissed a version warning banner for a given ver…
…sion. See pydata#1384 I think we all agree that if a user dismiss the banner it should apply to all pages. One remaining questions is : - does it apply to all versions ? This implement a rough dismiss button and store in local storage which version and **when** the user has dismissed it. I think this is enough informations to refine the logic later with what/when we want to show. This also has a rough implementation of not showing banner for current version for the next month following any banner dismissal. We could do the same for announcement (not implemented here), but also keep a hash of the announcement to re-show on new-announcement, but that's for another PR. CSS/HTML to refine, but I'll need help for that.
- Loading branch information
Showing
1 changed file
with
47 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters