Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added skip editing option #324

Merged
merged 4 commits into from Mar 9, 2022

Conversation

Devenom1
Copy link
Contributor

@Devenom1 Devenom1 commented Mar 6, 2022

closes #323

Added an option to skip editing the selected image entirely when not required[New Feature]

Description:

The user can now set an option to skip editing (cropping, flipping or rotating) the image entirely when not required. This can be useful when some places in your app don't require the image to be edited but you still want to use this library because of it's great functionality of picking and choosing images. This will help reduce user interactions in such cases

@Devenom1 Devenom1 requested a review from a team as a code owner March 6, 2022 02:31
Copy link
Member

@Canato Canato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR =D

Discussion on the linked issue

Don't forget the changelog update

@Canato
Copy link
Member

Canato commented Mar 7, 2022

branch need to be rebased for latest main

@Devenom1
Copy link
Contributor Author

Devenom1 commented Mar 8, 2022

branch need to be rebased for latest main

All Done @Canato 👍🏻

@Devenom1 Devenom1 requested a review from Canato March 8, 2022 23:14
Copy link
Member

@Canato Canato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Canato Canato merged commit 90d294e into CanHub:main Mar 9, 2022
@Canato Canato mentioned this pull request Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] - Add Skip Editing option to CropImageContractOptions
2 participants