Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ui-external url #1970

Merged
merged 6 commits into from Dec 27, 2023
Merged

Conversation

qdirks
Copy link
Contributor

@qdirks qdirks commented Jun 12, 2022

When browser-sync is serving files, this is what it prints in the console:

[Browsersync] Access URLs:
 --------------------------------------
       Local: http://localhost:3000
    External: http://192.168.0.242:3000
 --------------------------------------
          UI: http://localhost:3001
 UI External: http://localhost:3001         <-- This is not the external access url
 --------------------------------------
[Browsersync] Serving files from: ./

This pull request changes it to this:

[Browsersync] Access URLs:
 --------------------------------------
       Local: http://localhost:3000
    External: http://192.168.0.242:3000
 --------------------------------------
          UI: http://localhost:3001
 UI External: http://192.168.0.242:3001
 --------------------------------------
[Browsersync] Serving files from: ./

Copy link

@dippas dippas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cossssmin
Copy link

Any chance we can see this merged in the next patch release? 😇

@shakyShane shakyShane merged commit dc33c0b into BrowserSync:master Dec 27, 2023
@shakyShane
Copy link
Contributor

available in 3.0.2 :)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants