Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converter: add opnsense dnsmasq importer #1433

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

BeryJu
Copy link
Owner

@BeryJu BeryJu commented Jan 13, 2025

No description provided.

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for beryju-gravity canceled.

Name Link
🔨 Latest commit b65c5f5
🔍 Latest deploy log https://app.netlify.com/sites/beryju-gravity/deploys/67845d2dadd9840008afd035

Copy link

codecov bot commented Jan 13, 2025

Bundle Report

Changes will increase total bundle size by 679 bytes (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gravity-ui-esm 3.6MB 679 bytes (0.02%) ⬆️

@BeryJu BeryJu force-pushed the converter/add-opnsense branch from de5b0c3 to b65c5f5 Compare January 13, 2025 00:24
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 50.76923% with 64 lines in your changes missing coverage. Please review.

Project coverage is 60.20%. Comparing base (91326fb) to head (b65c5f5).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
pkg/convert/opnsense/convert.go 60.95% 29 Missing and 12 partials ⚠️
cmd/cli/cli_convert_opnsense.go 11.11% 16 Missing ⚠️
pkg/roles/dns/api_zones.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1433      +/-   ##
==========================================
- Coverage   60.33%   60.20%   -0.13%     
==========================================
  Files         142      144       +2     
  Lines        7903     8033     +130     
==========================================
+ Hits         4768     4836      +68     
- Misses       2674     2725      +51     
- Partials      461      472      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit ab69dd3 into main Jan 13, 2025
12 of 15 checks passed
@BeryJu BeryJu deleted the converter/add-opnsense branch January 13, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant