Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor vertex ai passthrough routes - fixes unpredictable behaviour w/ auto-setting default_vertex_region on router model add #9467

Merged
merged 10 commits into from
Mar 22, 2025

Conversation

krrishdholakia
Copy link
Contributor

@krrishdholakia krrishdholakia commented Mar 22, 2025

Title

Refactor vertex ai passthrough routes, to use common llm_passthrough_router handler

Relevant issues

fixes unpredictable behaviour w/ auto-setting default_vertex_region on router model add

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • I have added a screenshot of my new test passing locally
  • My PR passes all unit tests on (make test-unit)[https://docs.litellm.ai/docs/extras/contributing_code]
  • My PR's scope is as isolated as possible, it only solves 1 specific problem

Type

🐛 Bug Fix
🧹 Refactoring

Changes

  • uses common llm passthrough router across all passthrough routes
  • removes behaviour of setting default vertex region on new model add

Sorry, something went wrong.

…o use common llm passthrough handler.py
…vertex passthrough route
…ault vertex config
… not found on proxy
Copy link

vercel bot commented Mar 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2025 9:08pm

@krrishdholakia krrishdholakia changed the title Refactor vertex ai passthrough routes Refactor vertex ai passthrough routes - fixes unpredictable behaviour w/ auto-setting default_vertex_region on router model add Mar 22, 2025
@krrishdholakia krrishdholakia merged commit d3baaf7 into main Mar 22, 2025
25 of 39 checks passed
@krrishdholakia krrishdholakia deleted the litellm_dev_03_22_2025_p1 branch March 22, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant