Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils.py): Prevents final chunk w/ usage from being ignored #9314

Merged
merged 12 commits into from
Mar 17, 2025

Conversation

krrishdholakia
Copy link
Contributor

@krrishdholakia krrishdholakia commented Mar 17, 2025

Title

Logs the final chunk (with usage)

Relevant issues

Fixes #7112

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • I have added a screenshot of my new test passing locally
  • My PR passes all unit tests on (make test-unit)[https://docs.litellm.ai/docs/extras/contributing_code]
  • My PR's scope is as isolated as possible, it only solves 1 specific problem

Type

🆕 New Feature
🐛 Bug Fix
🧹 Refactoring
📖 Documentation
🚄 Infrastructure
✅ Test

Changes

Sorry, something went wrong.

… block given
…se stream with usage is always used
…to the streaming_handler

Removes incorrect logic for calculating complete streaming response from litellm logging
Copy link

vercel bot commented Mar 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 5:03pm

@krrishdholakia krrishdholakia changed the title Litellm dev 03 16 2025 p1 fix(utils.py): Prevents final chunk w/ usage from being ignored Mar 17, 2025
@krrishdholakia krrishdholakia merged commit 41d1a88 into main Mar 17, 2025
5 of 24 checks passed
@krrishdholakia krrishdholakia deleted the litellm_dev_03_16_2025_p1 branch March 17, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Bedrock Token Usage Reporting Streaming vs. Non-Streaming
1 participant