Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make masterkey secret configurable #9288

Merged

Conversation

mknet3
Copy link
Contributor

@mknet3 mknet3 commented Mar 16, 2025

Title

Add support for specifying custom Secrets for the master API key.

Relevant issues

Fixed #9147.
Fixed one of #8954

Pre-Submission checklist

Warning

This PR only introduces changes in Helm Chart. I've introduced a new command in the makefile to run Helm unit tests.

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • I have added a screenshot of my new test passing locally
  • My PR passes all unit tests on (make test-unit)[https://docs.litellm.ai/docs/extras/contributing_code]
  • My PR's scope is as isolated as possible, it only solves 1 specific problem

Type

🆕 New Feature
✅ Test

Changes

  • Added support for specifying masterkeySecretName and masterkeySecretKey in the Helm chart values.
  • Updated the deployment template to use the specified secret name and key for the master API key, with defaults if not specified.

New Tests:

  • Added unit tests for the new Helm chart values to ensure proper handling of masterkeySecretName and masterkeySecretKey.
  • Added tests for the secret creation logic to verify that a secret is created only when masterkeySecretName is not set.

Tests passing: https://github.com/BerriAI/litellm/actions/runs/13883013319/job/38844005616?pr=9288

image

Sorry, something went wrong.

Copy link

vercel bot commented Mar 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 16, 2025 11:47am

@mknet3 mknet3 marked this pull request as ready for review March 16, 2025 11:50
@mknet3 mknet3 mentioned this pull request Mar 16, 2025
6 tasks
@krrishdholakia krrishdholakia merged commit 97ed4d3 into BerriAI:main Mar 16, 2025
3 checks passed
@JakobStadlhuber
Copy link

Why is it still not available in the newest helm chart https://github.com/BerriAI/litellm/pkgs/container/litellm-helm/376247593?tag=0.1.639 @krrishdholakia ?

@krrishdholakia
Copy link
Contributor

Screenshot 2025-03-18 at 6 56 56 AM this is on main but not on a release yet

@JakobStadlhuber
Copy link

@krrishdholakia do you know when it will be in the release brach?

@krrishdholakia
Copy link
Contributor

Today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add an option to self manage master key to the helm chart
3 participants