Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Fixes RBAC] - for Internal User Viewer Permissions #9148

Merged
merged 3 commits into from
Mar 11, 2025

Conversation

ishaan-jaff
Copy link
Contributor

@ishaan-jaff ishaan-jaff commented Mar 11, 2025

[UI Fixes RBAC] - for Internal User Viewer Permissions

Added Coverage for the following scenarios:

  • Internal Viewer should not see
    • Only the follow pages are visible
      • Keys, Usage, Teams, API Ref, Model Hub, Logs
      • Nothing outside this set
    • Should not Test Key page
    • Keys Page
      • Should not see create key button
      • Click key, should not see edit delete or regenerate on root or on the key specific page
    • Teams Page
      • Should not see Members or Team settings page

Testing added to #8495

Relevant issues

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have Added testing in the tests/litellm/ directory, Adding at least 1 test is a hard requirement - see details
  • I have added a screenshot of my new test passing locally
  • My PR passes all unit tests on (make test-unit)[https://docs.litellm.ai/docs/extras/contributing_code]
  • My PR's scope is as isolated as possible, it only solves 1 specific problem

Type

🐛 Bug Fix
✅ Test

Changes

Sorry, something went wrong.

Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 6:54pm

@ishaan-jaff ishaan-jaff merged commit b728b04 into main Mar 11, 2025
34 of 37 checks passed
@krrishdholakia krrishdholakia deleted the litellm_fix_role_controls branch March 12, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant