Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add helm unittest #9068

Merged
merged 1 commit into from
Mar 11, 2025
Merged

ci: add helm unittest #9068

merged 1 commit into from
Mar 11, 2025

Conversation

mknet3
Copy link
Contributor

@mknet3 mknet3 commented Mar 8, 2025

Title

Configure unit tests for Helm Chart. This PR introduces a Helm unit test workflow and adds deployment tests to ensure the correctness of Helm charts.

Relevant issues

#8954

Type

✅ Test

Changes

Helm Unit Test Workflow:

  • .github/workflows/helm_unit_test.yml: Created a new GitHub Actions workflow named "Helm unit test" to run unit tests on pull requests and pushes to the main branch. This workflow sets up Helm 3.11.1, installs the Helm Unit Test Plugin, and runs the unit tests.

Deployment Tests:

  • deploy/charts/litellm-helm/tests/deployment_tests.yaml: Added a suite of deployment tests to verify different aspects of the deployment.yaml and configmap-litellm.yaml templates. These tests include checks for deployment kind, image tag, tolerations, and node affinity.

Copy link

vercel bot commented Mar 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 8, 2025 0:38am

@krrishdholakia
Copy link
Contributor

hey @mknet3 can you share a screenshot of your unit tests passing for you today?

@mknet3
Copy link
Contributor Author

mknet3 commented Mar 11, 2025

hey @krrishdholakia , I think better than a screenshot is the GHA workflow execution with the tests passing -> https://github.com/BerriAI/litellm/actions/runs/13731919612/job/38410438520

@mknet3
Copy link
Contributor Author

mknet3 commented Mar 11, 2025

But of course, I can paste it 🙂:
Screenshot 2025-03-11 at 17 47 56

@krrishdholakia krrishdholakia merged commit 12b37d2 into BerriAI:main Mar 11, 2025
3 checks passed
@krrishdholakia
Copy link
Contributor

Nice - thank you for adding this @mknet3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants