Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add Makefile for LiteLLM project with test targets #8948

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

colesmcintosh
Copy link
Contributor

Type

🚄 Infrastructure

Changes

  • Added a Makefile to simplify common development tasks
  • Implemented test targets for running all tests, unit tests, and integration tests
  • Added help command with documentation of available targets
  • Used poetry for running tests to maintain consistency with project's package management

Testing

No new tests or tested features introduced

The Makefile has been tested locally and all commands work as expected:

  • make help displays available commands
  • make test runs all tests
  • make test-unit runs only unit tests in tests/litellm/
  • make test-integration runs all tests except those in tests/litellm/

Copy link

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 3:45am

Copy link
Contributor

@ishaan-jaff ishaan-jaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job, can you help adding the rest of the checks that langchain has too @colesmcintosh https://python.langchain.com/docs/contributing/how_to/code/setup/#testing

they run linting and code spelling

@ishaan-jaff ishaan-jaff merged commit 5b2e8a5 into BerriAI:main Mar 10, 2025
1 check passed
@colesmcintosh
Copy link
Contributor Author

@ishaan-jaff absolutely, will work on adding those!

@ishaan-jaff
Copy link
Contributor

can you also add it to these docs: https://docs.litellm.ai/docs/extras/contributing_code

@colesmcintosh
Copy link
Contributor Author

Absolutely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants