Added tags, user_feedback and model_options to additional_keys which can be sent to athina #8845
+213
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@krrishdholakia @ishaan-jaff Please review. Thanks! |
ishaan-jaff
requested changes
Feb 27, 2025
litellm/integrations/athina.py
Outdated
| if key in metadata: | ||
| print("key is being added", key) |
There was a problem hiding this comment.
there are prints here, did you review your own code before asking us @vivek-athina ?
- please add unit tests in tests/litellm/integrations/test_athina.py
There was a problem hiding this comment.
Apologies for missing the prints. It was a mistake/oversight on my end.
Added units tests as suggested.
There was a problem hiding this comment.
@ishaan-jaff Can you please check again?
vivek-athina
changed the title
|
@krrishdholakia @ishaan-jaff Can you please review again? |
1 similar comment
|
@krrishdholakia @ishaan-jaff Can you please review again? |
|
@krrishdholakia @ishaan-jaff Can you please review again? |
|
@krrishdholakia @ishaan-jaff Can you please review again? |
Update main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Added tags, user_feedback and model_options to additional_keys which can be sent to athina
Type
🆕 New Feature
Changes
Added tags to additional_keys which are sent to Athina using the AthinaLogger
Screenshots of tests passing locally
Units Tests