Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bedrock.md for variable consistency #8185

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

superpoussin22
Copy link
Contributor

remove CUSTOM_ for consistency

Title

Standardize the variables name ( use always the same )
As the variables are also used by bedrock guardrails, remove CUSTOM_ prefix

Relevant issues

If CUSTOM_… is used bedrock guardrail don’t find the variables

Type

🐛 Bug Fix
🧹 Refactoring
📖 Documentation

Changes

@ishaan-jaff @krrishdholakia

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
remove CUSTOM_ for consistency
Copy link

vercel bot commented Feb 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2025 8:28pm

@krrishdholakia
Copy link
Contributor

Hey @superpoussin22 the key name shouldn't matter. It's just doing a os.getenv(). What exactly was the issue you ran into?

@superpoussin22
Copy link
Contributor Author

When you try to use bedrock guardrail , it fails if variable is CUSTOM_…..
nothing in the doc about credential when using bedrock guardrail , but removing CUSTOM_ allows me to go 1step further
I was using the example from the doc to setup the bedrock models and spent time to debug guardrail, so I thing using same names of variable would be fine to avoid confusion, in particular because there’s no instruction on bedrock guardrails doc in litellm to pass such info (@krrishdholakia I sent you more details a few days ago )

@ishaan-jaff
Copy link
Contributor

this makes sense, the doc should use the same env var name

@ishaan-jaff
Copy link
Contributor

Screenshot 2025-03-11 at 8 52 12 AM the doc starts with mentioning AWS_ vars, so @superpoussin22's fix makes it consistent

@ishaan-jaff ishaan-jaff merged commit 40525a5 into BerriAI:main Mar 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants