Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Litellm gh 3372 #3402

Merged
merged 2 commits into from
May 2, 2024
Merged

Litellm gh 3372 #3402

merged 2 commits into from
May 2, 2024

Conversation

msabramo
Copy link
Contributor

@msabramo msabramo commented May 2, 2024

#3375 but with a branch that starts with litellm_.

so that the `chat_completions` route is defined before the `completions` route.
This is necessary because the `chat_completions` route is more
specific than the `completions` route, and the order of route definitions
matters in FastAPI.

Without this, doing a request to
`/openai/deployments/{model_in_url}/chat/completions` might trigger
`completions` being called (with `model` set to `{model_in_url}/chat` instead of
`chat_completions` getting called, which is the correct function.

Fixes: BerriAIGH-3372
Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 5:31pm

@krrishdholakia krrishdholakia merged commit 152b5c8 into BerriAI:main May 2, 2024
2 checks passed
@msabramo msabramo deleted the litellm_GH-3372 branch May 2, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants