Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the deprecated prices attribute #51

Merged
merged 1 commit into from
May 25, 2023

Conversation

VrsajkovIvan33
Copy link

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Fetching new apps, like the Arin AI Chatbot one, started failing on private endpoints on May 14th. The following issue is reported:

Spaceship::UnexpectedResponse
The request cannot be fulfilled because of the state of another resource. - The resource 'appPrices' cannot be viewed, created or updated. Please view and create 'manualPrices' using the resource 'appPriceSchedules'.

Fastlane issue

Description

Remove prices from the essential includes. We are not using the prices field in the Bunker codebase.
Based on the fix introduced upstream.

Note that we are not rebasing our fastlane fork due to the uncertain future of the Bunkers project and because the fix is minor and easy to port over.

Testing Steps

Confirmed locally that we can fetch the AI Chatbot app when calling the /app_analytics endpoint.

@VrsajkovIvan33 VrsajkovIvan33 merged commit e5c8218 into master May 25, 2023
2 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants