Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced voronoi noise code #15117

Merged
merged 1 commit into from
May 20, 2024
Merged

Replaced voronoi noise code #15117

merged 1 commit into from
May 20, 2024

Conversation

lockphase
Copy link
Contributor

Pls see forum post on voronoi noise node artifact in nme.

@bjsplat
Copy link
Collaborator

bjsplat commented May 20, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented May 20, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented May 20, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented May 20, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15117/merge/testResults/webgpuplaywright/index.html

@Popov72
Copy link
Contributor

Popov72 commented May 20, 2024

I'm ok with the changes, the only thing is that it's a breaking change for people who use the existing function and weren't bothered by the bug...

What do you think @sebavan?

@deltakosh deltakosh merged commit 8b06ebc into BabylonJS:master May 20, 2024
11 checks passed
@deltakosh
Copy link
Contributor

I believe it is ok. We usually fix bugs even if the previous behavior was acceptable for some users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants