Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about missing dependency, but only once #14477

Merged
merged 1 commit into from Oct 31, 2023

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Oct 30, 2023

When the Ray import is missing no warning is shown when using the pick function (which is part of the default scene behavior).

This will display a single warning if Ray is not impoted. It also extends the warning mechanism to allow to throw/warn only once.

@RaananW
Copy link
Member Author

RaananW commented Oct 30, 2023

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 30, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 30, 2023

@RaananW RaananW merged commit dce706a into BabylonJS:master Oct 31, 2023
10 checks passed
@RaananW RaananW deleted the warnOnceMissingImport branch October 31, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants