Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking issue with ScriptBaseUrl #14472

Merged
merged 2 commits into from Oct 30, 2023

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Oct 27, 2023

The general idea here is this - change the ScriptBaseUrl functionality. If it is provided AND the URL is an absolute URL that starts with cdn.babylonjs.com, change this portion of the URL with the data provided in ScriptBaseURL

@RaananW RaananW marked this pull request as draft October 27, 2023 15:26
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 27, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 27, 2023

@RaananW RaananW marked this pull request as ready for review October 27, 2023 17:08
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wonder if the urls should be constructed from the constant _DefaultCdnUrl to prevent typos ?

@RaananW
Copy link
Member Author

RaananW commented Oct 28, 2023

Just wonder if the urls should be constructed from the constant _DefaultCdnUrl to prevent typos ?

That was the initial thought and this is why it is public, but that would force a dependency on tools right on load.
I guess most depend on tools anyhow, but it can be an optional dependency, whereas this forces it to be a required dependency.
I can make the change, as clean-code wise, it does make sense

@sebavan
Copy link
Member

sebavan commented Oct 28, 2023

It could also be in its own module but I guessed all the one with a url are automatically depending on tools in order to use it so I am not sure it would change anything.

@RaananW RaananW merged commit ac5bb82 into BabylonJS:master Oct 30, 2023
10 checks passed
@RaananW RaananW deleted the fixScriptBaseUrl branch October 30, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants