Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stack panel giving a warning for children with resizeToFit. #14452

Merged
merged 3 commits into from Oct 24, 2023
Merged

Fix stack panel giving a warning for children with resizeToFit. #14452

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00e884a
Fix stack panel giving a warning for children with resizeToFit.
carolhmj Oct 23, 2023
512fa56
Update packages/dev/gui/src/2D/controls/stackPanel.ts
carolhmj Oct 23, 2023
fa7e9d6
Update packages/dev/gui/src/2D/controls/stackPanel.ts
carolhmj Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/dev/gui/src/2D/controls/stackPanel.ts
View file
Open in desktop
Expand Up @@ -165,7 +165,7 @@ export class StackPanel extends Container {
child._top.ignoreAdaptiveScaling = true;
}

if (child._height.isPercentage && !child._automaticSize) {
if (child._height.isPercentage && !child._automaticSize && !(child as any)._resizeToFit) {
carolhmj marked this conversation as resolved.
Show resolved Hide resolved
if (!this.ignoreLayoutWarnings) {
Tools.Warn(`Control (Name:${child.name}, UniqueId:${child.uniqueId}) is using height in percentage mode inside a vertical StackPanel`);
}
Expand Down