Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unification and allowedHosts in local dev #14440

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Oct 18, 2023

I got a request to add allowedHosts to our dev server as an extra measure of security.

This PR unifies dev-server generation in all of our webpack configurations, and, of course, add allowedHosts as an optional environment variable.

After this is merged you will need to run npm install to get everything to work correctly.

@RaananW
Copy link
Member Author

RaananW commented Oct 18, 2023

CC @RolandCsibrei

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 18, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 18, 2023

@sebavan sebavan merged commit 73fa360 into BabylonJS:master Oct 18, 2023
10 checks passed
@RaananW RaananW deleted the extraFlagServer branch October 19, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants